"[SUREFIRE-2167] Simplify deserialization of elapsed time in TestSuiteXmlParser" did break compability with junit LegacyXmlReportGeneratingListener

[thomasmey]

Affected version

9e971d2

Bug description

This change did break the compatiblity with junit LegacyXmlReportGeneratingListener, I did add a comment to the old issue that explains it:
#2715 (comment)

Sadly this change did break the reporting of reports generated with LegacyXmlReportGeneratingListener in junit. The junit code seems create the time attributlike the maven-surefire reporting plugin did parse before, i.e. via NumberFormat.parse().
See also https://github.com/junit-team/junit-framework/blob/main/junit-platform-reporting/src/main/java/org/junit/platform/reporting/legacy/xml/XmlReportWriter.java#L167

For testsuites the Float.parse seems to work when the time number is smaller then 1000, the time attribute will look like this then: time="394.879", but when the testsuite runs longer the created time attribute will look like time="1,323.333", which make Float parse fail.

can you please revert this change and make things compatible again?

[akirsch76]

The cause of this problem is the change on the writing side in #2232, which was incorrect. The generated attribute does not conform to the xs:float definition in the XML schema for the surefire report. The grouping has been activated in the mentioned change, which is not supported in XML float attributes. A simple String.toString(float f) on the writing side would be enough. The toString / parseFloat method is independent of the current Locale.

[michael-o]

The cause of this problem is the change on the writing side in #2232, which was incorrect. The generated attribute does not conform to the xs:float definition in the XML schema for the surefire report. The grouping has been activated in the mentioned change, which is not supported in XML float attributes. A simple String.toString(float f) on the writing side would be enough. The toString / parseFloat method is independent of the current Locale.

This is why I changed it to be xs:float. The raised concern for the legacy stuff I proposed a simple fix which I am willing to apply.