libs/libc/stdio: close old file descriptor before reopening #17374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PengYinjie
requested review from
Donny9,
jerpelea and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: OS Components
jerpelea
changed the title
jerpelea
requested changes
Nov 25, 2025
Contributor
jerpelea
left a comment
jerpelea
left a comment
There was a problem hiding this comment.
please update commit title to
libs/libc/stdio:: close old file descriptor before reopening
jerpelea
changed the title
xiaoxiang781216
previously approved these changes
Nov 25, 2025
Updated freopen function in libc stdio to close the old file descriptor before reopening the file. Signed-off-by: pengyinjie <[email protected]>
Author
done. |
xiaoxiang781216
approved these changes
Nov 26, 2025
jerpelea
approved these changes
Nov 26, 2025
linguini1
requested changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated freopen function in libc stdio to close the old file descriptor before reopening the file.