arch/crt0.c: revert entry name to _start
#17450
Open
+18
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yf13
requested review from
jerpelea,
masayuki2009,
pussuw and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: Tooling
Arch: arm
| set(ENTRY_NAME "__start") | ||
| # same entry used for all build modes in crt0.c | ||
|
|
||
| set(ENTRY_NAME "_start") |
Contributor
There was a problem hiding this comment.
how about make file
1 task
This reverts crt0.c entry name to _start to fix LTO issue/17443, needs apps/ side pull/3235. Signed-off-by: Yanfeng Liu <[email protected]>
yf13
force-pushed
the
pull-crt0-start-naming
branch
from
bf5527b to
bcea169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.
This reverts original entry name to fix LTO issue/17443 together with apache/nuttx-apps#3235.
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Issue fix that shouldn't impact existing build processes.
Testing
This section should provide a detailed description of what you did
to verify your changes work and do not break existing code.
Please provide information about your host machine, the board(s) you
tested your changes on, and how you tested. Logs should be included.
For example, when changing something in the core OS functions, you
may want to run the OSTest application to verify that there are no
regressions. Changes to ADC code may warrant running the
adcexample. Adding a new uORB driver may require that you run
uorb_listenerto verify correct operation.Pure documentation changes can just be tested with
make html(see docs) and verification of the correct format in your
browser.
PRs without testing information will not be accepted. We will
request test logs.
qemu-armv7a:nsh,rv-virt:nshrv-virt:pnshqemu-armv7a:knsh,rv-virt:nsbi