Skip to content

Commit 25621d0

Browse files
zijun726911Zijun Wang
andauthored
Don't add finalizer for k8sService (#490)
Co-authored-by: Zijun Wang <[email protected]>
1 parent 9115298 commit 25621d0

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

controllers/service_controller.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ package controllers
1818

1919
import (
2020
"context"
21-
"fmt"
2221

2322
corev1 "k8s.io/api/core/v1"
2423
"k8s.io/apimachinery/pkg/runtime"
@@ -98,10 +97,6 @@ func (r *serviceReconciler) reconcile(ctx context.Context, req ctrl.Request) err
9897
}
9998
if !svc.DeletionTimestamp.IsZero() {
10099
r.finalizerManager.RemoveFinalizers(ctx, svc, serviceFinalizer)
101-
} else {
102-
if err := r.finalizerManager.AddFinalizers(ctx, svc, serviceFinalizer); err != nil {
103-
r.eventRecorder.Event(svc, corev1.EventTypeWarning, k8s.ServiceEventReasonFailedAddFinalizer, fmt.Sprintf("failed and finalizer: %s", err))
104-
}
105100
}
106101

107102
r.log.Infow("reconciled", "name", req.Name)

0 commit comments

Comments
 (0)