Skip to content

Don't wrap ResourceNotFoundException #20

Description

@estyxx

If the secret is not on AWS Secrets Manager the client will throw a ResourceNotFoundException that will be wrapped in SecretCacheObject.__refresh

I think to wrap ResourceNotFoundException is not good practice: because after the client application has no way to understand that something is wrong in the configuration of Aws SM, and if you have a hook it will be triggered anyway even if an exception occurred and the value is None.
[the implementation of SecretCacheHook will receive cached_obj = None in the get method]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions