diff --git a/erc4626/SuperformSuperVaultReview.md b/erc4626/SuperformSuperVaultReview.md deleted file mode 100644 index a95eab3..0000000 --- a/erc4626/SuperformSuperVaultReview.md +++ /dev/null @@ -1,42 +0,0 @@ -# ERC4626 Vault: `SuperVault` - -## Details -- Reviewed by: @mattpereira -- Checked by: @mkflow27 -- Deployed at: - - [ethereum:0xF7DE3c70F2db39a188A81052d2f3C8e3e217822a](https://etherscan.io/address/0xF7DE3c70F2db39a188A81052d2f3C8e3e217822a#code) - - [base:0xe9F2a5F9f3c846f29066d7fB3564F8E6B6b2D65b](https://basescan.org/address/0xe9F2a5F9f3c846f29066d7fB3564F8E6B6b2D65b#code) -- Audit report(s): - - [SuperVaults Audits](https://github.com/superform-xyz/SuperVaults/tree/main/audits) - -## Context -A SuperVault manages multiple Superforms (Superform positions linked to vaults) and incorporates mechanisms for rebalancing, whitelisting, and deposit limits. SuperVault contracts delegate most of their core ERC-4626 vault functionality to the Yearn V3 TokenizedStrategy contract. - -## Review Checklist: Bare Minimum Compatibility -Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. - -- [ ] Tests based on the [balancer-v3-monorepo](https://github.com/balancer/balancer-v3-monorepo/tree/main/pkg/vault/test/foundry/fork) pass for the given ERC4626 vaults, which can be found [here](https://github.com/balancer/balancer-v3-erc4626-tests/tree/main/test). -- [x] The required Vault implements the required operational ERC4626 Interface - -## Review Checklist: Common Findings -Each of the items below represents a common red flag found in Rate Provider contracts. - -If none of these is checked, then this might be a pretty great Rate Provider! If any of these is checked, we must thoroughly elaborate on the conditions that lead to the potential issue. Decision points are not binary; a Rate Provider can be safe despite these boxes being checked. A check simply indicates that thorough vetting is required in a specific area, and this vetting should be used to inform a holistic analysis of the Rate Provider. - -### Administrative Privileges -- [ ] The ERC4626 Vault is upgradeable (e.g., via a proxy architecture or an `onlyOwner` function that updates the price source address). - -### Compatibility -- [x] The reviewed ERC4626 Vault shall be used for swaps. -- [x] The reviewed ERC4626 Vault shall be used to add and remove liquidity to pools using wrapped tokens. -- [ ] The reviewed ERC4626 Vault shall be used to add and remove liquidity to pools using underlying tokens. - -### Common Manipulation Vectors -- [ ] The ERC4626 Vault is susceptible to donation attacks. - -## Additional Findings -To save time, we do not bother pointing out low-severity/informational issues or gas optimizations (unless the gas usage is particularly egregious). Instead, we focus only on high- and medium-severity findings which materially impact the contract's functionality and could harm users. - -## Conclusion -**Summary judgment: USABLE** -The outlined ERC4626 Vaults should work with Balancer pools, but are not compatible with buffers since `testWithdraw` reverts with "too much loss", perhaps because SuperVaults leverage Yearn v3 `TokenizedStrategy` contract, which requires profits to be gradually unlocked over time, making it difficult to guarantee immediate withdrawals at the expected share price. Fork tests can be seen [here](https://github.com/balancer/balancer-v3-erc4626-tests/pull/24) \ No newline at end of file diff --git a/erc4626/registry.json b/erc4626/registry.json index f97c3f3..bfcb612 100644 --- a/erc4626/registry.json +++ b/erc4626/registry.json @@ -196,18 +196,6 @@ } }, "base": { - "0xe9F2a5F9f3c846f29066d7fB3564F8E6B6b2D65b": { - "asset": "0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913", - "name": "Superform USDC", - "summary": "safe", - "review": "./SuperformSuperVaultReview.md", - "warnings": [ - "buffer" - ], - "canUseBufferForSwaps": false, - "useUnderlyingForAddRemove": false, - "useWrappedForAddRemove": true - }, "0x616a4E1db48e22028f6bbf20444Cd3b8e3273738": { "asset": "0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913", "name": "MetaMorpho v1.1 Seamless USDC", @@ -400,18 +388,6 @@ } }, "ethereum": { - "0xF7DE3c70F2db39a188A81052d2f3C8e3e217822a": { - "asset": "0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48", - "name": "Superform USDC", - "summary": "safe", - "review": "./SuperformSuperVaultReview.md", - "warnings": [ - "buffer" - ], - "canUseBufferForSwaps": false, - "useUnderlyingForAddRemove": false, - "useWrappedForAddRemove": true - }, "0x2371e134e3455e0593363cBF89d3b6cf53740618": { "asset": "0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2", "name": "MetaMorpho Gauntlet wETH Prime", @@ -2767,4 +2743,4 @@ "useWrappedForAddRemove": true } } -} \ No newline at end of file +}