From 2e5f91218bdea086ddc9fc9e489757206d2ab3c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Sun, 26 Apr 2026 13:52:07 +0100 Subject: [PATCH 1/7] fix an probem with task's noexcept specifications --- CMakeLists.txt | 6 +++--- include/beman/task/detail/task.hpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 51b5e44..dfba767 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -28,9 +28,9 @@ include(FetchContent) FetchContent_Declare( execution - # FETCHCONTENT_SOURCE_DIR_EXECUTION ${CMAKE_SOURCE_DIR}/../execution - GIT_REPOSITORY https://github.com/bemanproject/execution - GIT_TAG cad563e + SOURCE_DIR ${CMAKE_SOURCE_DIR}/../execution + # GIT_REPOSITORY https://github.com/bemanproject/execution + # GIT_TAG cad563e SYSTEM FIND_PACKAGE_ARGS 0.2.0 diff --git a/include/beman/task/detail/task.hpp b/include/beman/task/detail/task.hpp index 22510be..b6bd549 100644 --- a/include/beman/task/detail/task.hpp +++ b/include/beman/task/detail/task.hpp @@ -70,7 +70,7 @@ class task { ~task() = default; template - auto connect(Receiver receiver) && -> state { + auto connect(Receiver&& receiver) && noexcept -> state { return state(std::forward(receiver), std::move(this->handle)); } template From 80b06887e7b06156584657be7e74304f0da193a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Mon, 27 Apr 2026 04:24:34 -0400 Subject: [PATCH 2/7] bump to new execution version --- CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index dfba767..a333ae9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -28,9 +28,9 @@ include(FetchContent) FetchContent_Declare( execution - SOURCE_DIR ${CMAKE_SOURCE_DIR}/../execution - # GIT_REPOSITORY https://github.com/bemanproject/execution - # GIT_TAG cad563e + # FETCHCONTENT_SOURCE_DIR_EXECUTION ${CMAKE_SOURCE_DIR}/../execution + GIT_REPOSITORY https://github.com/bemanproject/execution + GIT_TAG afde940 SYSTEM FIND_PACKAGE_ARGS 0.2.0 From 533a2faafe32cb7e6bd5219351129711077768d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Mon, 27 Apr 2026 12:03:26 +0100 Subject: [PATCH 3/7] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- include/beman/task/detail/task.hpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/include/beman/task/detail/task.hpp b/include/beman/task/detail/task.hpp index b6bd549..bad9a92 100644 --- a/include/beman/task/detail/task.hpp +++ b/include/beman/task/detail/task.hpp @@ -70,8 +70,11 @@ class task { ~task() = default; template - auto connect(Receiver&& receiver) && noexcept -> state { - return state(std::forward(receiver), std::move(this->handle)); + auto connect(Receiver&& receiver) && + noexcept(noexcept(state>(std::forward(receiver), + std::move(this->handle)))) + -> state> { + return state>(std::forward(receiver), std::move(this->handle)); } template auto as_awaitable(ParentPromise&) && -> ::beman::task::detail::awaiter { From e42e69e60764c1441b6f4ac87fb18484f1cd5dd9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Mon, 27 Apr 2026 07:06:06 -0400 Subject: [PATCH 4/7] clang-format --- include/beman/task/detail/task.hpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/beman/task/detail/task.hpp b/include/beman/task/detail/task.hpp index bad9a92..c74087d 100644 --- a/include/beman/task/detail/task.hpp +++ b/include/beman/task/detail/task.hpp @@ -70,10 +70,9 @@ class task { ~task() = default; template - auto connect(Receiver&& receiver) && - noexcept(noexcept(state>(std::forward(receiver), - std::move(this->handle)))) - -> state> { + auto connect(Receiver&& receiver) && noexcept( + noexcept(state>(std::forward(receiver), std::move(this->handle)))) + -> state> { return state>(std::forward(receiver), std::move(this->handle)); } template From 1a41ea1c41c4504a088164422f14d611b570a5aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Mon, 27 Apr 2026 07:07:31 -0400 Subject: [PATCH 5/7] minor formatting issue --- include/beman/task/detail/task.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/beman/task/detail/task.hpp b/include/beman/task/detail/task.hpp index c74087d..82c9af2 100644 --- a/include/beman/task/detail/task.hpp +++ b/include/beman/task/detail/task.hpp @@ -50,7 +50,7 @@ class task { using completion_signatures = ::beman::execution::detail::meta::combine< ::beman::execution::completion_signatures, ::beman::execution::set_stopped_t()>, - ::beman::task::detail::error_types_of_t >; + ::beman::task::detail::error_types_of_t>; template auto get_completion_signatures(const Ev&) const& noexcept -> completion_signatures { return {}; From a7e71367b98b3047bb0858dd55db9564d5daebc8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Mon, 27 Apr 2026 18:21:33 -0400 Subject: [PATCH 6/7] fix an issue a missing noexcept on a constructor --- include/beman/task/detail/state.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/beman/task/detail/state.hpp b/include/beman/task/detail/state.hpp index 204d823..e746d19 100644 --- a/include/beman/task/detail/state.hpp +++ b/include/beman/task/detail/state.hpp @@ -31,7 +31,7 @@ struct state : ::beman::task::detail::state_base, ::beman::task::detail::s }; using stop_callback_t = ::beman::execution::stop_callback_for_t; template - state(R&& r, H h) + state(R&& r, H h) noexcept//-dk:TODO break down to various members : state_rep(std::forward(r)), handle(std::move(h)), scheduler(this->template from_env(::beman::execution::get_env(this->receiver))) {} From 2020c7eca985482172280a6b9b1d18b6c79d73b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Mon, 27 Apr 2026 18:22:44 -0400 Subject: [PATCH 7/7] clang format --- include/beman/task/detail/state.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/beman/task/detail/state.hpp b/include/beman/task/detail/state.hpp index e746d19..4aa146d 100644 --- a/include/beman/task/detail/state.hpp +++ b/include/beman/task/detail/state.hpp @@ -31,7 +31,7 @@ struct state : ::beman::task::detail::state_base, ::beman::task::detail::s }; using stop_callback_t = ::beman::execution::stop_callback_for_t; template - state(R&& r, H h) noexcept//-dk:TODO break down to various members + state(R&& r, H h) noexcept //-dk:TODO break down to various members : state_rep(std::forward(r)), handle(std::move(h)), scheduler(this->template from_env(::beman::execution::get_env(this->receiver))) {}