feat(agent-ui): add embed-frame support for nav items #1761
+578
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add behavior and autoActive options to WorkspaceNavItem interface - Implement embed-frame rendering with iframe in workspace - Add state management for active embed frames per session - Support auto-activation of embed frames on load - Handle embed frame dismissal when tool content is shown - Update navbar to show active state and handle toggle behavior
❌ Deploy Preview for tarko failed.
|
ulivz
changed the title
- Add proper conditions to prevent unnecessary embed frame clearing - Only clear embed frame for real tool call results, not loading states - Improve auto-activation logic to avoid repeated triggers - Ensure embed frame state stability during tool call processing
- Create unified WorkspaceDisplayState with explicit modes (idle, embed-frame, tool-content) - Replace separate embed frame and panel content atoms with single workspace state - Add convenience action atoms (showEmbedFrame, hideEmbedFrame, showToolContent) - Simplify WorkspacePanel rendering with switch-based content display - Update Navbar and ToolHandler to use new state management - Eliminate state conflicts and flickering issues through unified state model
- Add hasAutoActivated flag to track auto-activation state - Prevent re-activation when user manually hides embed frame - Reset flag when session changes - Ensure user intent takes precedence over auto-activation
…tuck - Separate src change handling from event listener setup - Set up event listeners only once on mount - Reset loading state when src changes - Prevent race conditions between listener cleanup and setup
- Remove complex loading state management and event listeners - Let browser handle iframe loading naturally - Reduce bundle size by removing unnecessary complexity - Keep only essential error handling for missing URLs
- Use fixed dimensions instead of responsive scaling - Prevent contain/cover scaling behavior - Maintain consistent iframe size across different screens
- Center iframe in container with flex layout - Use maxWidth/maxHeight for responsive scaling - Apply contain-style scaling to fit within container - Maintain aspect ratio while ensuring full visibility
ulivz
force-pushed
the
feat/workspace-embed-frame
branch
from
ff82f5e to
f99348a
Compare
- Remove fixed width/height constraints - Let iframe fill container completely - Simplify to basic responsive behavior
- Reduce iframe dimensions to prevent VNC content overflow - Use more compact size that fits typical screen layouts - Maintain aspect ratio while reducing footprint
- Calculate iframe dimensions from container size - Use 80% of container space with 1280x958 max limit - Maintain 4:3 aspect ratio to prevent distortion - Handle window resize events responsively
- Remove 80% limitation for maximum utilization - Use full container width and height - Maintain aspect ratio and size caps
- Change layout to align iframe at top instead of center - Add Open button in top-right corner to open in new tab - Add fullscreen mode with Close button - Improve UI with proper button styling and icons
ulivz
force-pushed
the
feat/workspace-embed-frame
branch
from
05ab1d4 to
8fbe0ff
Compare
- Add check in ToolHandler to respect active embed-frame state - Update Message components to use new unified state management - Ensure embed-frame stays active until manually dismissed - Allow tool blocks to override embed-frame when clicked
- add ResizeObserver for container width change detection - align frame to top center for better positioning - move open-in-new-tab button to title area
- redesign EmbedFrameView header with gradient and modern styling - add elegant title with animated pulse indicator - improve open-in-new-tab button with hover effects - implement HDR-style active state for navbar items - add gradient overlays, shadows, and animations to active buttons - enhance mobile menu active states with visual indicators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add behavior and autoActive options to WorkspaceNavItem interface
Checklist