Skip to content

Commit 92989cf

Browse files
jnthntatumcopybara-github
authored andcommitted
Bump cel-spec version.
Re-enable fixed conformance tests. PiperOrigin-RevId: 966718346
1 parent 604cc57 commit 92989cf

3 files changed

Lines changed: 9 additions & 12 deletions

File tree

MODULE.bazel

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,12 @@ git_override(
2424
)
2525

2626
# https://registry.bazel.build/modules/cel-spec
27-
bazel_dep(name = "cel-spec", version = "0.25.1", repo_name = "com_google_cel_spec")
27+
bazel_dep(name = "cel-spec", version = "0.25.3", repo_name = "com_google_cel_spec")
28+
git_override(
29+
module_name = "cel-spec",
30+
commit = "ba58ae5007845f3a1279b488cdeb79645ce958bb",
31+
remote = "https://github.com/cel-expr/cel-spec",
32+
)
2833

2934
# https://registry.bazel.build/modules/googletest
3035
bazel_dep(name = "googletest", version = "1.17.0.bcr.2", repo_name = "com_google_googletest")

conformance/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ _ALL_TESTS = [
1414
"@com_google_cel_spec//tests/simple:testdata/fp_math.textproto",
1515
"@com_google_cel_spec//tests/simple:testdata/integer_math.textproto",
1616
"@com_google_cel_spec//tests/simple:testdata/lists.textproto",
17+
"@com_google_cel_spec//tests/simple:testdata/lists_ext.textproto",
1718
"@com_google_cel_spec//tests/simple:testdata/logic.textproto",
1819
"@com_google_cel_spec//tests/simple:testdata/macros.textproto",
1920
"@com_google_cel_spec//tests/simple:testdata/math_ext.textproto",

conformance/conformance_test.py

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,6 @@ class ConformanceTestSuite(unittest.TestSuite):
6060
"fields/qualified_identifier_resolution/qualified_identifier_resolution_unchecked",
6161
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
6262
"namespace/namespace/self_eval_container_lookup_unchecked",
63-
# TODO(b/453051120): fix support for FieldMask->toJson
64-
"wrappers/field_mask/to_json",
65-
# TODO(b/464071224): fix support for triple-quoted unescaped punctuation.
66-
"parse/bytes_literals/triple_double_quoted_unescaped_punctuation",
67-
"parse/bytes_literals/triple_single_quoted_unescaped_punctuation",
68-
"parse/string_literals/triple_double_quoted_unescaped_punctuation",
69-
"parse/string_literals/triple_single_quoted_unescaped_punctuation",
7063
# Recent changes
7164
"proto2/set_null/repeated_field_timestamp_null_pruned",
7265
"proto2/set_null/repeated_field_duration_null_pruned",
@@ -80,10 +73,8 @@ class ConformanceTestSuite(unittest.TestSuite):
8073
"proto3/set_null/map_timestamp_null_pruned",
8174
"proto3/set_null/map_duration_null_pruned",
8275
"proto3/set_null/map_wrapper_null_pruned",
83-
"string_ext/format/default precision for fixed-point clause with int",
84-
"string_ext/format/default precision for fixed-point clause with uint",
85-
"string_ext/format/default precision for scientific notation with int",
86-
"string_ext/format/default precision for scientific notation with uint",
76+
# TODO(b/548571767): add lists_ext support
77+
"lists_ext/.*",
8778
]
8879

8980
if sys.platform == "win32":

0 commit comments

Comments
 (0)