remove rls bindings

Author: Shubham8287

crates/bindings/src/client_visibility_filter.rs

@@ -6,8 +6,6 @@ use core::ops::Deref;
 use spacetimedb_lib::bsatn;
 use std::rc::Rc;
 
-#[cfg(feature = "unstable")]
-mod client_visibility_filter;
 #[cfg(feature = "unstable")]
 pub mod http;
 pub mod log_stopwatch;
@@ -22,8 +20,6 @@ pub mod table;
 #[doc(hidden)]
 pub use spacetimedb_query_builder as query_builder;
 
-#[cfg(feature = "unstable")]
-pub use client_visibility_filter::Filter;
 pub use log;
 #[cfg(feature = "rand")]
 pub use rand08 as rand;
@@ -61,44 +57,6 @@ pub type ProcedureResult = Vec<u8>;
 
 pub use spacetimedb_bindings_macro::duration;
 
-/// Generates code for registering a row-level security rule.
-///
-/// This attribute must be applied to a `const` binding of type [`Filter`].
-/// It will be interpreted as a filter on the table to which it applies, for all client queries.
-/// If a module contains multiple `client_visibility_filter`s for the same table,
-/// they will be unioned together as if by SQL `OR`,
-/// so that any row permitted by at least one filter is visible.
-///
-/// The `const` binding's identifier must be unique within the module.
-///
-/// The query follows the same syntax as a subscription query.
-///
-/// ## Example:
-///
-/// ```no_run
-/// # #[cfg(target_arch = "wasm32")] mod demo {
-/// use spacetimedb::{client_visibility_filter, Filter};
-///
-/// /// Players can only see what's in their chunk
-/// #[client_visibility_filter]
-/// const PLAYERS_SEE_ENTITIES_IN_SAME_CHUNK: Filter = Filter::Sql("
-///     SELECT * FROM LocationState WHERE chunk_index IN (
-///         SELECT chunk_index FROM LocationState WHERE entity_id IN (
-///             SELECT entity_id FROM UserState WHERE identity = :sender
-///         )
-///     )
-/// ");
-/// # }
-/// ```
-///
-/// Queries are not checked for syntactic or semantic validity
-/// until they are processed by the SpacetimeDB host.
-/// This means that errors in queries, such as syntax errors, type errors or unknown tables,
-/// will be reported during `spacetime publish`, not at compile time.
-#[cfg(feature = "unstable")]
-#[doc(inline, hidden)] // TODO: RLS filters are currently unimplemented, and are not enforced.
-pub use spacetimedb_bindings_macro::client_visibility_filter;
-
 /// Declares a table with a particular row type.
 ///
 /// This attribute is applied to a struct type with named fields.

crates/bindings/src/lib.rs

@@ -803,13 +803,6 @@ where
     })
 }
 
-/// Registers a row-level security policy.
-pub fn register_row_level_security(sql: &'static str) {
-    register_describer(|module| {
-        module.inner.add_row_level_security(sql);
-    })
-}
-
 /// A builder for a module.
 #[derive(Default)]
 pub struct ModuleBuilder {

crates/bindings/src/rt.rs

@@ -787,9 +787,6 @@ define_tables! {
 #[spacetimedb::reducer]
 fn no_op_succeeds(_ctx: &ReducerContext) {}
 
-#[spacetimedb::client_visibility_filter]
-const ONE_U8_VISIBLE: spacetimedb::Filter = spacetimedb::Filter::Sql("SELECT * FROM one_u8");
-
 #[spacetimedb::table(name = scheduled_table, scheduled(send_scheduled_message), public)]
 pub struct ScheduledTable {
     #[primary_key]
@@ -825,9 +822,6 @@ struct BTreeU32 {
     data: i32,
 }
 
-#[spacetimedb::client_visibility_filter]
-const USERS_FILTER: spacetimedb::Filter = spacetimedb::Filter::Sql("SELECT * FROM users WHERE identity = :sender");
-
 #[spacetimedb::table(name = users, public)]
 struct Users {
     #[primary_key]

modules/sdk-test/src/lib.rs

@@ -134,7 +134,6 @@ fn main() {
         "test-intra-query-bag-semantics-for-join" => test_intra_query_bag_semantics_for_join(),
         "two-different-compression-algos" => exec_two_different_compression_algos(),
         "test-parameterized-subscription" => test_parameterized_subscription(),
-        "test-rls-subscription" => test_rls_subscription(),
         "pk-simple-enum" => exec_pk_simple_enum(),
         "indexed-simple-enum" => exec_indexed_simple_enum(),
 
@@ -2548,67 +2547,6 @@ fn test_parameterized_subscription() {
     ctr_for_test.wait_for_all();
 }
 
-/// In this test we have two clients subscribe to the `users` table.
-/// Access to this table is controlled using the following RLS rule:
-/// ```rust
-/// #[spacetimedb::client_visibility_filter]
-/// const USERS_FILTER: spacetimedb::Filter = spacetimedb::Filter::Sql(
-///     "SELECT * FROM users WHERE identity = :sender"
-/// );
-/// ```
-/// Hence each client should receive different rows.
-fn test_rls_subscription() {
-    let ctr_for_test = TestCounter::new();
-    let ctr_for_subs = TestCounter::new();
-    let sub_0 = Some(ctr_for_subs.add_test("sub_0"));
-    let sub_1 = Some(ctr_for_subs.add_test("sub_1"));
-    let ins_0 = Some(ctr_for_test.add_test("insert_0"));
-    let ins_1 = Some(ctr_for_test.add_test("insert_1"));
-
-    fn subscribe_and_update(
-        test_name: &str,
-        user_name: &str,
-        waiters: [Arc<TestCounter>; 2],
-        senders: [Option<ResultRecorder>; 2],
-    ) {
-        let [ctr_for_test, ctr_for_subs] = waiters;
-        let [mut record_sub, mut record_ins] = senders;
-        let user_name = user_name.to_owned();
-        let expected_name = user_name.to_owned();
-        connect_with_then(&ctr_for_test, test_name, |builder| builder, {
-            move |ctx| {
-                let sender = ctx.identity();
-                let expected_identity = sender;
-                subscribe_these_then(ctx, &["SELECT * FROM users"], move |ctx| {
-                    put_result(&mut record_sub, Ok(()));
-                    // Wait to insert until both client connections have been made
-                    ctr_for_subs.wait_for_all();
-                    ctx.reducers.insert_user(user_name, sender).unwrap();
-                });
-                ctx.db.users().on_insert(move |_, user| {
-                    assert_eq!(user.name, expected_name);
-                    assert_eq!(user.identity, expected_identity);
-                    put_result(&mut record_ins, Ok(()));
-                });
-            }
-        });
-    }
-
-    subscribe_and_update(
-        "client_0",
-        "Alice",
-        [ctr_for_test.clone(), ctr_for_subs.clone()],
-        [sub_0, ins_0],
-    );
-    subscribe_and_update(
-        "client_1",
-        "Bob",
-        [ctr_for_test.clone(), ctr_for_subs.clone()],
-        [sub_1, ins_1],
-    );
-    ctr_for_test.wait_for_all();
-}
-
 fn exec_pk_simple_enum() {
     let test_counter: Arc<TestCounter> = TestCounter::new();
     let mut updated = Some(test_counter.add_test("updated"));

sdks/rust/tests/test-client/src/main.rs

@@ -261,11 +261,6 @@ macro_rules! declare_tests_with_suffix {
                 make_test("test-parameterized-subscription").run();
             }
 
-            #[test]
-            fn test_rls_subscription() {
-                make_test("test-rls-subscription").run()
-            }
-
             #[test]
             fn pk_simple_enum() {
                 make_test("pk-simple-enum").run();