fix: replace empty() with strict isset/bool check to satisfy PHPStan

gr8man · gr8man · commit c9e6eaf6a930 · 2026-07-06T19:49:18.000+02:00
diff --git a/system/HTTP/CURLRequest.php b/system/HTTP/CURLRequest.php
@@ -783,7 +783,7 @@ private function applyResponseOptions(array $curlOptions, array $config): array
      */
     private function applyProtocolOptions(array $curlOptions, array $config): array
     {
-        if (empty($config['version'])) {
+        if (! isset($config['version']) || (bool) $config['version'] === false) {
             return $curlOptions;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -783,7 +783,7 @@ private function applyResponseOptions(array $curlOptions, array $config): array`
`783`	`783`	`*/`
`784`	`784`	`private function applyProtocolOptions(array $curlOptions, array $config): array`
`785`	`785`	`{`
`786`		`- if (empty($config['version'])) {`
	`786`	`+ if (! isset($config['version']) \|\| (bool) $config['version'] === false) {`
`787`	`787`	`return $curlOptions;`
`788`	`788`	`}`
`789`	`789`