fix: remove redundant null check for string typed parameter in MessageTrait

gr8man · gr8man · commit dc8de2141bf8 · 2026-07-03T23:40:31.000+02:00
diff --git a/system/HTTP/MessageTrait.php b/system/HTTP/MessageTrait.php
@@ -283,8 +283,8 @@ protected function getHeaderName(string $name): string
      */
     public function setProtocolVersion(string $version): self
     {
-        // If empty or null, keep default protocol version (usually 1.1) and do nothing.
-        if ($version === '' || $version === null) {
+        // If empty, keep default protocol version (usually 1.1) and do nothing.
+        if ($version === '') {
             return $this;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -283,8 +283,8 @@ protected function getHeaderName(string $name): string`
`283`	`283`	`*/`
`284`	`284`	`public function setProtocolVersion(string $version): self`
`285`	`285`	`{`
`286`		`- // If empty or null, keep default protocol version (usually 1.1) and do nothing.`
`287`		`- if ($version === '' \|\| $version === null) {`
	`286`	`+ // If empty, keep default protocol version (usually 1.1) and do nothing.`
	`287`	`+ if ($version === '') {`
`288`	`288`	`return $this;`
`289`	`289`	`}`
`290`	`290`