test: confirm pnpm global bin layout in #149 probe

Run 2 showed pnpm setup reports global bin = %PNPM_HOME%\bin (= %LOCALAPPDATA%
\pnpm\bin), matching the #149 report, but the in-process global install didn't
land a shim. Configure global-bin-dir explicitly and install a tiny package
(cowsay) to reveal pnpm's real .cmd path/casing, then launch that absolute shim
directly to confirm a hardcoded-path fix needs no cmd /C wrapper.

Author: ualtinok

.github/workflows/win-opencode-probe.yml

@@ -25,39 +25,41 @@ jobs:
         run: cargo test win_cmd_shim_execution_probe -- --ignored --nocapture
 
       # --- Real-world reproduction: a pnpm-global opencode, exactly like #149. ---
-      - name: Install opencode via pnpm (reproduce #149 layout)
+      - name: Confirm pnpm global .cmd shim layout (#149 mechanism 1)
         shell: pwsh
         continue-on-error: true
         run: |
           npm install -g pnpm
-          # pnpm global installs need PNPM_HOME established first; `pnpm setup`
-          # writes it to the user env. Apply it to this process so `add -g` lands.
-          pnpm setup 2>&1 | Out-Host
-          if (-not $env:PNPM_HOME) { $env:PNPM_HOME = "$env:LOCALAPPDATA\pnpm" }
-          $env:PATH = "$env:PNPM_HOME;$env:PATH"
-          pnpm add -g opencode-ai 2>&1 | Out-Host
-          Write-Host "PNPM_HOME=$env:PNPM_HOME"
+          # pnpm's global bin dir is %PNPM_HOME%\bin (= %LOCALAPPDATA%\pnpm\bin),
+          # which is exactly the #149 layout. Configure + PATH it in-process so a
+          # global install actually lands, then observe where the .cmd shim goes.
+          $env:PNPM_HOME = "$env:LOCALAPPDATA\pnpm"
+          $binDir = Join-Path $env:PNPM_HOME "bin"
+          New-Item -ItemType Directory -Force -Path $binDir | Out-Null
+          $env:PATH = "$binDir;$env:PNPM_HOME;$env:PATH"
+          pnpm config set global-bin-dir "$binDir"
           Write-Host "pnpm bin -g => $(pnpm bin -g 2>$null)"
-          Write-Host "--- opencode* under PNPM_HOME ---"
-          $shims = Get-ChildItem -Recurse -Filter "opencode*" "$env:PNPM_HOME" -ErrorAction SilentlyContinue | Select-Object -ExpandProperty FullName
-          $shims | ForEach-Object { Write-Host $_ }
-          Write-Host "--- where.exe opencode (PATH includes pnpm now) ---"
-          where.exe opencode 2>&1 | Out-Host
-          # Capture the real .cmd shim absolute path for the next step (each run
-          # step is a fresh shell, so pass it via GITHUB_ENV rather than PATH).
-          $cmdShim = $shims | Where-Object { $_ -like "*opencode.cmd" } | Select-Object -First 1
-          if ($cmdShim) { "OPENCODE_SHIM=$cmdShim" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8 }
+          # A tiny package with a bin is enough to reveal pnpm's shim path/casing;
+          # the heavy opencode-ai install is unnecessary to confirm the LOCATION.
+          pnpm add -g cowsay 2>&1 | Out-Host
+          Write-Host "--- *.cmd placed by pnpm ---"
+          $cmds = Get-ChildItem -Recurse -Filter "*.cmd" "$env:PNPM_HOME" -ErrorAction SilentlyContinue | Select-Object -ExpandProperty FullName
+          $cmds | ForEach-Object { Write-Host $_ }
+          # Pass one real pnpm-placed shim to the next step to launch directly.
+          $shim = $cmds | Select-Object -First 1
+          if ($shim) { "OPENCODE_SHIM=$shim" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8 }
 
-      - name: Probe the real pnpm shim (direct vs cmd /C)
+      - name: Probe the real pnpm shim (direct launch)
         shell: pwsh
         continue-on-error: true
         run: |
-          # Use the absolute pnpm shim path captured above. A GUI launch of the
-          # dashboard would NOT have pnpm on PATH (mechanism 1), so testing the
-          # absolute path is the faithful question: given the path, does a direct
-          # CreateProcessW launch (identical to Rust's Command) succeed?
+          # A GUI launch of the dashboard would NOT have pnpm on PATH (mechanism
+          # 1), so the faithful question is: given the absolute pnpm shim path,
+          # does a direct CreateProcessW launch (identical to Rust's Command)
+          # succeed? If yes, hardcoding the pnpm path in the candidate list fixes
+          # #149 with no cmd /C wrapper needed.
           $shim = $env:OPENCODE_SHIM
-          if (-not $shim) { Write-Host "pnpm opencode.cmd shim not found; skipping"; exit 0 }
+          if (-not $shim) { Write-Host "no pnpm .cmd shim captured; skipping"; exit 0 }
           Write-Host "resolved shim: $shim"
 
           function Try-Launch($file, $arguments) {