-
Notifications
You must be signed in to change notification settings - Fork 26
chart: drop redundant int() wrapper around cidrPrefixLen calls #166
Copy link
Copy link
Closed
Labels
area/chartIssues or PRs related to charts/ (Chart.yaml, helpers, templates)Issues or PRs related to charts/ (Chart.yaml, helpers, templates)kind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debtCategorizes issue or PR as related to cleanup of code, process, or technical debtpriority/backlogGeneral backlog priority. Lower than priority/important-longtermGeneral backlog priority. Lower than priority/important-longterm
Metadata
Metadata
Assignees
Labels
area/chartIssues or PRs related to charts/ (Chart.yaml, helpers, templates)Issues or PRs related to charts/ (Chart.yaml, helpers, templates)kind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debtCategorizes issue or PR as related to cleanup of code, process, or technical debtpriority/backlogGeneral backlog priority. Lower than priority/important-longtermGeneral backlog priority. Lower than priority/important-longterm
cidrPrefixLen(engine helper inpkg/engine/helm/engine.go) returns Goint. Two chart-side callers wrap it in Sprig'sint:charts/talm/templates/_helpers.tpl:151— insideaddresses_by_linkfiltercharts/talm/templates/_helpers.tpl:564— insidedefault_addresses_by_gatewayfilter (added in fix(charts): pin Layer2VIPConfig to subnet-matching link, not default route #163)The third caller in the same file (
link_name_for_addressline 429) uses the bare form$prefixLen := cidrPrefixLen $addressdirectly. The outerintis a no-op; dropping it brings the three call sites into one consistent style.Reference: PR #163 review, flagged as non-blocking.