-
Notifications
You must be signed in to change notification settings - Fork 26
init --update without --preset: redundant double-message error #179
Copy link
Copy link
Closed
Labels
area/commandsIssues or PRs related to pkg/commands (CLI subcommands, flag parsing, root detection)Issues or PRs related to pkg/commands (CLI subcommands, flag parsing, root detection)area/initIssues or PRs related to talm init (project bootstrap, encrypt/decrypt, --update flow)Issues or PRs related to talm init (project bootstrap, encrypt/decrypt, --update flow)good first issueGood for newcomersGood for newcomerskind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debtCategorizes issue or PR as related to cleanup of code, process, or technical debtpriority/backlogGeneral backlog priority. Lower than priority/important-longtermGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked onIndicates an issue is ready to be actively worked on
Metadata
Metadata
Assignees
Labels
area/commandsIssues or PRs related to pkg/commands (CLI subcommands, flag parsing, root detection)Issues or PRs related to pkg/commands (CLI subcommands, flag parsing, root detection)area/initIssues or PRs related to talm init (project bootstrap, encrypt/decrypt, --update flow)Issues or PRs related to talm init (project bootstrap, encrypt/decrypt, --update flow)good first issueGood for newcomersGood for newcomerskind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debtCategorizes issue or PR as related to cleanup of code, process, or technical debtpriority/backlogGeneral backlog priority. Lower than priority/important-longtermGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked onIndicates an issue is ready to be actively worked on
Problem
talm init --updatein a project without an explicit--presetflag AND without a preset dependency inChart.yamlemits a doubly-wrapped error message:The string
preset is requiredessentially says the same thing aspreset not found in Chart.yaml dependencies. The duplication makes the error harder to read.Reproduction
Output:
Origin:
pkg/commands/init.go:768:"preset not found in Chart.yaml dependencies"(already with hint).pkg/commands/init.go:1094:errors.Wrap(err, "preset is required: use --preset flag or ensure Chart.yaml has a preset dependency").The outer wrap layers another full sentence on top of the inner error, producing the colon-separated double.
Expected
Either:
errors.Wrap(err, "init --update").Option 1 is cleaner and one-line.
Why this matters
The redundant double-statement is a small UX smell, but it's the operator's first impression after a fresh
init --updatefailure. Cleaning it up takes one line.Surfaced during the dev17 manual test plan exercise.