Duplicated subscriptions on local development

[zalito12]

Description

When you are working on local development with forwarded stripe events, the customer.subscription.created and customer.subscription.updated events are received almost at the same time and, as updating use createOrUpdateSubscription, the subscriptions are created 2 times.

My idea is to use a specific update method instead of

stripe/src/services/Webhooks.php

Line 97 in fa70b83

$plugin->getSubscriptions()->createOrUpdateSubscription($subscription);

Steps to reproduce

1. Up local development with stripe forwarded
2. Create a subscription
3. Subscription is duplicated

Additional info

• Craft version: 5.40
• PHP version: 8.2
• Database driver & version: Mysql
• Plugins & versions: 1.1.0

[sunnylawn]

I'm also seeing this

[lukeholder]

Thanks for the reports. I will take a look into this one and see if we can reproduce.

[AdamChlan]

I'm going to add our experience with this issue, in case it is helpful. Locally, I never did get the webhooks working 100%, so I would manually sync the data back down to my local from stripe. Not a big deal to do that. When I manually sync, it would correctly sync down 1 subscription per invoice.

When I pushed the work to staging, I too was noticing that running through the subscription process was returning two subscription entries for a user via the web hook. I'm thinking this issue is not limited to local development work. The subscriptions have the same ID, so perhaps it won't be a problem, but likely not ideal.

[zalito12]

I think the problem is the use of getOrCreate, I'm not developing this integration rn, but when I was, I saw that, to get the subscription it was using a get or create method in two different points, which creates a race condition.
I changed one of them to get, and it stopped creating two records.

[lukeholder]

Thanks all, I have a draft PR created #88. Will update you all here once it goes into a release.

[AdamChlan]

Hi @lukeholder. I was curious if you plan on releasing this. Any timeline in mind, if so?

[lukeholder]

Hi @AdamChlan yes, we should have a release out soon, I will follow up now.

[i-just]

Stripe 1.6.0 is out with that fix. Thanks again!

[pimago]

@i-just I am on 1.6.0 but I am still getting duplicate subscriptions Also with the same Stripe Id.
It happens on local and on staging.

[lukeholder]

@i-just I am on 1.6.0 but I am still getting duplicate subscriptions Also with the same Stripe Id. It happens on local and on staging.

thanks for reporting, I am reopening the issue.