Devcontainer fails to start

[dreamoutbox]

Hi, I tried contributing to deadpool-redis using GitHub Codespaces, but the devcontainer fails to start.

The issue appears to come from redis-sentinel in docker-compose, where the referenced image tag no longer exists.

While looking into this, I also noticed the devcontainer build takes a long time because it installs cargo-release and cargo-outdated via cargo install. It might be better to move these to postCreateCommand to speed up image builds.

I also noticed that even small changes trigger a full Docker image rebuild. Adding a .dockerignore file might help avoid unnecessary rebuilds.

I’ll open a PR with fixes once I’ve cleaned this up.

[bikeshedder]

I left a few comments on the PR and totally missed that issue where you explain your reasoning.

The issue appears to come from redis-sentinel in docker-compose, where the referenced image tag no longer exists.

I completely forgot about those pesky bitnami images. I'd be awesome to get rid of redis and bitnami altogether and replace it by a proper valkey image. Any ideas?

While looking into this, I also noticed the devcontainer build takes a long time because it installs cargo-release and cargo-outdated via cargo install. It might be better to move these to postCreateCommand to speed up image builds.

I'm a bit on the fence regarding this. It does speed up container builds but now you end up with a rather long postCreateCommand that needs to run anyways. So it's just delaying the unavoidable. With the code being part of the Dockerfile you could build them ahead of time (e.g. via a CI Action) and use that ready-build image instead.

I know deadpool doesn't have that and probably never will ... it's just that I use this kind of setup for all my projects.

I also noticed that even small changes trigger a full Docker image rebuild. Adding a .dockerignore file might help avoid unnecessary rebuilds.

I do wonder why that happens. Normally changing anything in the .devcontainer directory unless referenced by the Dockerfile should not require a rebuild. Any ideas what could be happing here?