Skip to content

Commit 9ea5222

Browse files
committed
fix: disable firefox cache to test a potential root cause for the build failures
The builds have worked briefly after changes that invalidate this cache, then failed again. While running some of these builds interactively to investigate this issue, I noticed they got auto-updated, I think this changed recently, and it's what's causing the builds to fail when caching the firefox builds, because each downloaded build will work with Marionette only once. What might happen is: - On the first buiild FF will start to download an update autommatically - We cached this FF installation - On the next build, Marionette won't be abe to connect to FF The reason why the second launch could be that the first run of FF was too short for the download to complete (I would say unlikely, I'm sure the devs account for the possibility of an incomplete download of the update) or maybe the update process needs to run during startup, preventing Marionette from connecting. If disabling the cache fixes the builds, it's likely the auto-update is the issue.
1 parent 4fed8c2 commit 9ea5222

1 file changed

Lines changed: 13 additions & 13 deletions

File tree

.github/workflows/rust.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -63,19 +63,19 @@ jobs:
6363
key: ${{ runner.os }}-pip2-${{ hashFiles('integration_tests/requirements.txt') }}
6464
restore-keys: |
6565
${{ runner.os }}-pip2-
66-
- name: Cache firefox versions
67-
uses: actions/cache@v4
68-
# TODO: restoring the cache still makes sense since the latest version might
69-
# match one we test in the CI build, but we should ensure there is no full
70-
# key match so that the existing cache is not overwritten. We could include
71-
# the current timestamp in the key.
72-
if: github.event_name != 'schedule'
73-
with:
74-
path: |
75-
${{ env.XDG_CACHE_HOME }}/extension_testing
76-
key: ${{ runner.os }}-ff2-${{ hashFiles('integration_tests/firefox_versions', 'integration_tests/firefox.py') }}
77-
restore-keys: |
78-
${{ runner.os }}-ff2-
66+
# - name: Cache firefox versions
67+
# uses: actions/cache@v4
68+
# # TODO: restoring the cache still makes sense since the latest version might
69+
# # match one we test in the CI build, but we should ensure there is no full
70+
# # key match so that the existing cache is not overwritten. We could include
71+
# # the current timestamp in the key.
72+
# if: github.event_name != 'schedule'
73+
# with:
74+
# path: |
75+
# ${{ env.XDG_CACHE_HOME }}/extension_testing
76+
# key: ${{ runner.os }}-ff2-${{ hashFiles('integration_tests/firefox_versions', 'integration_tests/firefox.py') }}
77+
# restore-keys: |
78+
# ${{ runner.os }}-ff2-
7979
- name: Run integration tests
8080
if: github.event_name != 'schedule'
8181
# CI run, test against the versions we specify in the firefox_versions file

0 commit comments

Comments
 (0)