You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Across 8 total cases, 7 passed and 1 failed: merge-harness and matcher-precision checks were largely stable, confirming the configured vector-index skip remained active, non-matching and near-match queries still executed, title drift behavior matched expectations, and repeated runs were deterministic. The key finding was a High-severity release-signal defect introduced by this PR: TestDoltMerge can report green while the vector-index merge scenario (“three-way merge of table with vector index”) is deterministically excluded via SkipQueryTest substring matching, so CI pass status can mask an untested compatibility gap.
Tests run by Ito
Result
Severity
Type
Description
❌
Compatibility
The suite can pass while excluding three-way merge of table with vector index, so the reported green signal does not prove vector-merge compatibility coverage.
✅
—
Compatibility
TestDoltMerge completed successfully while explicitly signaling that VECTOR merge coverage is intentionally skipped for dialect compatibility reasons.
✅
—
Matcher
Controlled broad-token probe showed overlap risk only when an intentionally generic skip fragment was injected.
✅
—
Matcher
Non-matching query text remained executable with the current vector skip phrase configured.
✅
—
Matcher
Current vector-index skip phrase stayed specific in focused checks and did not trigger near-match suppression.
✅
—
Merge
TestDoltMerge completed successfully and the vector-index merge scenario remained excluded via the configured skip phrase.
✅
—
Merge
The harness behavior was verified: when upstream title text drifts, the literal skip phrase no longer matches and the renamed case stays executable.
✅
—
Merge
Two consecutive TestDoltMerge runs stayed stable, showing skip entries were preserved on the execution harness with no ordering loss.
Tip
Reply with @itoqa to send us feedback on this test run.
These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.