You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩
Across 13 QA cases, 12 passed and 1 failed, showing broad success across authentication flows, query/portal protocol behavior, COPY ingestion scenarios, and startup/replication bootstrap and recovery checks. The most important issue is a SCRAM nonce-mismatch classification bug where tampered logins are correctly rejected but reported as internal error XX000 with implementation-detail text instead of generic auth failure 28P01, while valid login, unknown-user privacy parity, OID inference, extended-query ordering, COPY retry correctness, TLS startup, and restart/reconfiguration recovery all worked as expected.
Tests run by Ito
Result
Severity
Type
Description
✅
—
Auth
Valid SCRAM login reached query-ready state and successful SELECT responses.
✅
—
Auth
Invalid credentials for known and unknown users produced equivalent password-auth failure behavior.
✅
—
Copy
COPY FROM STDIN text mode inserted and committed 3 rows as expected.
✅
—
Copy
COPY retry after a mid-stream failure completed cleanly with only retry rows persisted.
✅
—
Query
Simple query execution returned row data and completed cleanly in the remediation run.
✅
—
Query
Parse with parameter OID 0 inferred types correctly and returned expected row output.
Fresh empty-data startup created the default postgres database and accepted client queries.
✅
—
Startup
With a complete replication configuration and source prerequisites in place, logical replication started successfully.
✅
—
Startup
TLS-enabled startup path accepted SSL negotiation and authenticated queries in the rerun verification.
✅
—
Startup
After an intentionally failed bootstrap attempt, immediate restart with corrected settings recovered cleanly.
✅
—
Startup
After a deliberate replication-init failure, corrected replication settings recovered service and replication worker startup.
⚠️
Auth
The server correctly rejects the tampered nonce, but it returns FATAL XX000 with invalid SASLResponse: nonce does not match authentication session instead of a generic password/authentication failure classification.
Additional Findings Details
These findings are unrelated to the current changes but were observed during testing.
🟡 SCRAM nonce mismatch returns internal error class
Severity: Medium
Description: The server correctly rejects the tampered nonce, but it returns FATAL XX000 with invalid SASLResponse: nonce does not match authentication session instead of a generic password/authentication failure classification.
Impact: Clients receive an internal-error SQLSTATE and implementation-detail text on a login failure path, which weakens error semantics on a core authentication workflow. Login still fails closed, so users are blocked from sign-in only for malformed/tampered handshakes.
Steps to Reproduce:
Start the server with authentication enabled.
Begin SCRAM login and capture the server nonce from AuthenticationSASLContinue.
Send a crafted SASLResponse with a different nonce and inspect the returned SQLSTATE and message.
Stub / mock content: No stubs, mocks, or bypasses were applied for this test in the recorded run.
Code Analysis: I inspected server/authentication_scram.go and server/connection_handler.go. Nonce mismatch is detected in readSASLResponse, and that specific parse error is surfaced as XX000 in the auth handler rather than auth-failure class 28P01, while later proof-verification failures do use 28P01.
Tip
Reply with @itoqa to send us feedback on this test run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕ An Automated Dependency Version Bump PR 👑
Initial Changes
The changes contained in this PR were produced by `go get`ing the dependency.
```bash
go get github.com/dolthub/[dependency]/go@[commit]
```