Allow multiple error ids on catchers #285
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
.catcher()method to accept multiple error codes via an array, improving developer ergonomics when handling groups of related HTTP status codes with the same error handler.Motivation
Previously, catching multiple error codes required chaining multiple
.catcher()calls with the same handler:This was verbose and repetitive. The enhancement allows:
Changes
Implementation (
src/core.ts).catcher()to accept both single error IDs and arraysType Definitions (
src/types.ts)errorId: number | string | symbol→errorId: ErrorId | ErrorId[]ErrorIdtype export for reusabilityDocumentation (
README.md)Tests (
test/shared/wretch.spec.ts)Added 4 comprehensive test cases:
Testing
All tests passing (78/78):
Code coverage: 98.52% statements, 95.62% branches
Backward Compatibility
✅ Fully backward compatible - single error IDs work exactly as before:
CONTRIBUTING.md Compliance