From eccda5ede918c1e438c59ea32f2cce3853ff846f Mon Sep 17 00:00:00 2001 From: Ryo Nakano Date: Sun, 6 Sep 2026 16:13:45 +0900 Subject: [PATCH 1/3] ListHeader: Make sure to use app name, not class name --- src/Widgets/ListHeader.vala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Widgets/ListHeader.vala b/src/Widgets/ListHeader.vala index 1a36836b..0c40431b 100644 --- a/src/Widgets/ListHeader.vala +++ b/src/Widgets/ListHeader.vala @@ -44,7 +44,7 @@ public class Notifications.ListHeader : Granite.Bin { construct { var image = new Gtk.Image.from_icon_name ("pan-end-symbolic"); - var label = new Granite.HeaderLabel (name) { + var label = new Granite.HeaderLabel (app_name) { hexpand = true, size = H3 }; @@ -65,7 +65,7 @@ public class Notifications.ListHeader : Granite.Bin { clear_btn_image.add_css_class ("sweep-animation"); var clear_btn_entry = new Gtk.Button () { - tooltip_text = _("Clear all %s notifications").printf (name), + tooltip_text = _("Clear all %s notifications").printf (app_name), child = clear_btn_image, has_frame = false }; From 702c9553a6b6c72f058c8f7b95b295f5d0af11db Mon Sep 17 00:00:00 2001 From: Ryo Nakano Date: Sun, 6 Sep 2026 16:22:28 +0900 Subject: [PATCH 2/3] Make sure to update the tooltip when app_name is set --- src/Widgets/ListHeader.vala | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/Widgets/ListHeader.vala b/src/Widgets/ListHeader.vala index 0c40431b..b3ebe91d 100644 --- a/src/Widgets/ListHeader.vala +++ b/src/Widgets/ListHeader.vala @@ -79,6 +79,12 @@ public class Notifications.ListHeader : Granite.Bin { child = box; bind_property ("app-name", label, "label"); + bind_property ("app-name", clear_btn_entry, "tooltip-text", DEFAULT, + (binding, app_name, ref tooltip_text) => { + tooltip_text = _("Clear all %s notifications").printf ((string) app_name); + return true; + }, + () => { return false; }); expander.toggled.connect (() => { headers[app_id] = expander.active; From 84e5a772af0028d6c84e3caef9776a3b560507e6 Mon Sep 17 00:00:00 2001 From: Ryo Nakano Date: Sun, 6 Sep 2026 16:26:37 +0900 Subject: [PATCH 3/3] Fix indentation, make sure to use different variable names --- src/Widgets/ListHeader.vala | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Widgets/ListHeader.vala b/src/Widgets/ListHeader.vala index b3ebe91d..cb5e1ca3 100644 --- a/src/Widgets/ListHeader.vala +++ b/src/Widgets/ListHeader.vala @@ -80,11 +80,11 @@ public class Notifications.ListHeader : Granite.Bin { bind_property ("app-name", label, "label"); bind_property ("app-name", clear_btn_entry, "tooltip-text", DEFAULT, - (binding, app_name, ref tooltip_text) => { - tooltip_text = _("Clear all %s notifications").printf ((string) app_name); - return true; - }, - () => { return false; }); + (binding, _app_name, ref _tooltip_text) => { + _tooltip_text = _("Clear all %s notifications").printf ((string) _app_name); + return true; + }, + () => { return false; }); expander.toggled.connect (() => { headers[app_id] = expander.active;