Skip to content

Fix media type with optional parameters #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leungkkf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix media type with optional parameters #7739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/egui_extras/src/loaders/image_loader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,11 @@ fn is_supported_mime(mime: &str) -> bool {
}
}

// Some servers may return a media type with an optional parameter, e.g. "image/jpeg; charset=utf-8".
let (mime_type, _) = mime.split_once(';').unwrap_or((mime, ""));

// Uses only the enabled image crate features
ImageFormat::from_mime_type(mime).is_some_and(|format| format.reading_enabled())
ImageFormat::from_mime_type(mime_type).is_some_and(|format| format.reading_enabled())
}

impl ImageLoader for ImageCrateLoader {
Expand Down
Loading