Skip to content

Commit c4d1505

Browse files
authored
Merge pull request #18855 from ghouscht/backport-defrag-close-temp-3.4
[3.4] fix(defrag): close temp file in case of error
2 parents 29145e8 + d5bf838 commit c4d1505

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

mvcc/backend/backend.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -470,6 +470,15 @@ func (b *backend) defrag() error {
470470
tdbp := temp.Name()
471471
tmpdb, err := bolt.Open(tdbp, 0600, &options)
472472
if err != nil {
473+
temp.Close()
474+
if rmErr := os.Remove(temp.Name()); rmErr != nil && b.lg != nil {
475+
b.lg.Error(
476+
"failed to remove temporary file",
477+
zap.String("path", temp.Name()),
478+
zap.Error(rmErr),
479+
)
480+
}
481+
473482
return err
474483
}
475484

0 commit comments

Comments
 (0)