Raise exception in runner failed to start. Clean logs in CLI run.

Author: Aksem

finecode/logs.py

@@ -58,7 +58,7 @@ def save_logs_to_file(
         encoding="utf8",
         filter=filter_logs,
     )
-    logger.info(f"Log file: {file_path}")
+    logger.trace(f"Log file: {file_path}")
 
 
 def set_log_level_for_group(group: str, level: LogLevel | None):

finecode/workspace_manager/cli_app/run.py

@@ -99,7 +99,7 @@ def get_projects_by_names(
 def find_projects_with_actions(
     ws_context: context.WorkspaceContext, actions: list[str]
 ) -> dict[pathlib.Path, list[str]]:
-    actions_by_project: dict[pathlib.Path, list[str]] = []
+    actions_by_project: dict[pathlib.Path, list[str]] = {}
     actions_set = ordered_set.OrderedSet(actions)
 
     for project in ws_context.ws_projects.values():

finecode/workspace_manager/logger_utils.py

@@ -13,7 +13,7 @@ def init_logger(trace: bool, stdout: bool = False):
     logger.remove()
     # disable logging raw messages
     # TODO: make configurable
-    logger.configure(activation=[("pygls.protocol.json_rpc", False)])
+    logger.configure(activation=[("pygls.protocol.json_rpc", False), ("pygls.feature_manager", False)])
     logs.save_logs_to_file(
         file_path=log_dir_path / "execution.log",
         log_level="TRACE" if trace else "INFO",

finecode/workspace_manager/lsp_server/services.py

@@ -61,15 +61,23 @@ async def add_workspace_dir(
 
     global_state.ws_context.ws_dirs_paths.append(dir_path)
     await read_configs.read_projects_in_dir(dir_path, global_state.ws_context)
-    await runner_manager.update_runners(global_state.ws_context)
+    try:
+        await runner_manager.update_runners(global_state.ws_context)
+    except runner_manager.RunnerFailedToStart:
+        # user sees status in client(IDE), no need to raise explicit error
+        ...
     return schemas.AddWorkspaceDirResponse()
 
 
 async def delete_workspace_dir(
     request: schemas.DeleteWorkspaceDirRequest,
 ) -> schemas.DeleteWorkspaceDirResponse:
     global_state.ws_context.ws_dirs_paths.remove(Path(request.dir_path))
-    await runner_manager.update_runners(global_state.ws_context)
+    try:
+        await runner_manager.update_runners(global_state.ws_context)
+    except runner_manager.RunnerFailedToStart:
+        # user sees status in client(IDE), no need to raise explicit error
+        ...
     return schemas.DeleteWorkspaceDirResponse()
 
 
@@ -86,4 +94,8 @@ async def handle_changed_ws_dirs(added: list[Path], removed: list[Path]) -> None
                 " but not found in ws context"
             )
 
-    await runner_manager.update_runners(global_state.ws_context)
+    try:
+        await runner_manager.update_runners(global_state.ws_context)
+    except runner_manager.RunnerFailedToStart:
+        # user sees status in client(IDE), no need to raise explicit error
+        ...

finecode/workspace_manager/runner/manager.py

@@ -222,13 +222,18 @@ async def update_runners(ws_context: context.WorkspaceContext) -> None:
         runner.working_dir_path: runner for runner in extension_runners
     }
 
-    init_runners_coros = [
-        _init_runner(
-            runner, ws_context.ws_projects[runner.working_dir_path], ws_context
-        )
-        for runner in extension_runners
-    ]
-    await asyncio.gather(*init_runners_coros)
+    try:
+        async with asyncio.TaskGroup() as tg:
+            for runner in extension_runners:
+                tg.create_task(
+                    _init_runner(
+                runner, ws_context.ws_projects[runner.working_dir_path], ws_context
+                    )
+                )
+    except ExceptionGroup as eg:
+        for exception in eg.exceptions:
+            logger.exception(exception)
+        raise RunnerFailedToStart("Failed to initialize runner")
 
 
 async def _init_runner(
@@ -250,7 +255,7 @@ async def _init_runner(
         project.status = domain.ProjectStatus.RUNNER_FAILED
         await notify_project_changed(project)
         runner.initialized_event.set()
-        return
+        raise RunnerFailedToStart(f"Runner failed to initialize: {error}")
 
     try:
         await runner_client.notify_initialized(runner)
@@ -260,7 +265,8 @@ async def _init_runner(
         await notify_project_changed(project)
         runner.initialized_event.set()
         logger.exception(error)
-        return
+        raise RunnerFailedToStart(f"Runner failed to notify about initialization: {error}")
+
     logger.debug("LSP Server initialized")
 
     await read_configs.read_project_config(project=project, ws_context=ws_context)
@@ -278,7 +284,7 @@ async def _init_runner(
         project.status = domain.ProjectStatus.RUNNER_FAILED
         await notify_project_changed(project)
         runner.initialized_event.set()
-        return
+        raise RunnerFailedToStart(f"Runner failed to update config: {error}")
 
     logger.debug(
         f"Updated config of runner {runner.working_dir_path},"