Change message keys in LSP messages for action tree from snake case to camel case

Author: Aksem

docs/reference/lsp-protocol.md

@@ -51,9 +51,12 @@ Server APIs. Params are passed as the `params` array of `executeCommand`.
 ### Action Tree and Projects
 
 - `finecode.getActions`
-  - Params: `parent_node_id` (string or `null`)
+  - Params: `parentNodeId` (string or `null`), or positional string argument
   - Returns: action tree under the given node
 
+Action tree node payloads use camelCase fields in the LSP protocol:
+`nodeId`, `nodeType`, `subnodes`, `status`, `name`.
+
 - `finecode.getActionsForPosition`
   - Params: position object (currently ignored)
   - Returns: action tree (currently full tree)

docs/wm-protocol.md

@@ -358,15 +358,15 @@ Get the hierarchical action tree for IDE sidebar display.
 {
   "nodes": [
     {
-      "node_id": "ws_dir_0",
+      "nodeId": "ws_dir_0",
       "name": "/path/to/workspace",
-      "node_type": 0,
+      "nodeType": 0,
       "status": "ok",
       "subnodes": [
         {
-          "node_id": "project_0",
+          "nodeId": "project_0",
           "name": "finecode",
-          "node_type": 1,
+          "nodeType": 1,
           "status": "ok",
           "subnodes": []
         }
@@ -376,7 +376,7 @@ Get the hierarchical action tree for IDE sidebar display.
 }
 ```
 
-`node_type` values: 0=DIRECTORY, 1=PROJECT, 2=ACTION, 3=ACTION_GROUP, 4=PRESET,
+`nodeType` values: 0=DIRECTORY, 1=PROJECT, 2=ACTION, 3=ACTION_GROUP, 4=PRESET,
 5=ENV_GROUP, 6=ENV
 
 ---
@@ -782,9 +782,9 @@ runner start/stop).
 ```json
 {
   "node": {
-    "node_id": "project_0",
+    "nodeId": "project_0",
     "name": "finecode",
-    "node_type": 1,
+    "nodeType": 1,
     "status": "ok",
     "subnodes": []
   }

src/finecode/lsp_server/endpoints/action_tree.py

@@ -5,13 +5,38 @@
 from pygls.lsp.server import LanguageServer
 
 
+def _parse_parent_node_id(params) -> str | None:
+    """Parse getActions executeCommand params (camelCase protocol)."""
+    if params is None:
+        return None
+
+    if isinstance(params, str):
+        return params
+
+    if isinstance(params, dict):
+        return params.get("parentNodeId")
+
+    if isinstance(params, list):
+        if len(params) == 0:
+            return None
+        first = params[0]
+        if isinstance(first, str):
+            return first
+        if isinstance(first, dict):
+            return first.get("parentNodeId")
+
+    return None
+
+
+async def notify_changed_action_node(ls: LanguageServer, action_node: dict) -> None:
+    ls.protocol.notify(method="actionsNodes/changed", params=action_node)
+
+
 async def list_actions(ls: LanguageServer, params):
     logger.info(f"list_actions {params}")
     await global_state.server_initialized.wait()
 
-    # params is expected to be a list, but pygls seems to pass the first element of list
-    # if the list contains only one element. Test after migration from pygls
-    parent_node_id = params  # params[0]
+    parent_node_id = _parse_parent_node_id(params)
 
     if global_state.wm_client is None:
         raise Exception()

src/finecode/lsp_server/lsp_server.py

@@ -245,10 +245,9 @@ async def _on_initialized(ls: LanguageServer, params: types.InitializedParams):
 
     # Register notification handlers for server→client push messages.
     async def on_tree_changed(params: dict) -> None:
-        # TODO
-        ...
-        # node = schemas.ActionTreeNode(**params["node"])
-        # await action_tree_endpoints.notify_changed_action_node(ls, node)
+        node = params.get("node")
+        if isinstance(node, dict):
+            await action_tree_endpoints.notify_changed_action_node(ls, node)
 
     async def on_user_message(params: dict) -> None:
         await send_user_message_notification(ls, params["message"], params["type"])

src/finecode/wm_server/services/action_tree.py

@@ -36,18 +36,18 @@ def _project_action_tree(project: domain.Project | None, ws_context: context.Wor
                 handler_node_id = f"{project.dir_path.as_posix()}::{action.name}::{handler.name}"
                 handlers_nodes.append(
                     {
-                        "node_id": handler_node_id,
+                        "nodeId": handler_node_id,
                         "name": handler.name,
-                        "node_type": 2,  # ACTION
+                        "nodeType": 2,  # ACTION
                         "subnodes": [],
                         "status": "",
                     }
                 )
             action_nodes.append(
                 {
-                    "node_id": node_id,
+                    "nodeId": node_id,
                     "name": action.name,
-                    "node_type": 2,  # ACTION
+                    "nodeType": 2,  # ACTION
                     "subnodes": handlers_nodes,
                     "status": "",
                 }
@@ -61,9 +61,9 @@ def _project_action_tree(project: domain.Project | None, ws_context: context.Wor
         node_id = f"{project.dir_path.as_posix()}::actions"
         actions_nodes.append(
             {
-                "node_id": node_id,
+                "nodeId": node_id,
                 "name": "Actions",
-                "node_type": 3,  # ACTION_GROUP
+                "nodeType": 3,  # ACTION_GROUP
                 "subnodes": action_nodes,
                 "status": "",
             }
@@ -74,19 +74,19 @@ def _project_action_tree(project: domain.Project | None, ws_context: context.Wor
             env_node_id = f"{project.dir_path.as_posix()}::envs::{env}"
             envs_nodes.append(
                 {
-                    "node_id": env_node_id,
+                    "nodeId": env_node_id,
                     "name": env,
-                    "node_type": 6,  # ENV
+                    "nodeType": 6,  # ENV
                     "subnodes": [],
                     "status": "",
                 }
             )
         node_id = f"{project.dir_path.as_posix()}::envs"
         actions_nodes.append(
             {
-                "node_id": node_id,
+                "nodeId": node_id,
                 "name": "Environments",
-                "node_type": 5,  # ENV_GROUP
+                "nodeType": 5,  # ENV_GROUP
                 "subnodes": envs_nodes,
                 "status": "",
             }
@@ -135,10 +135,10 @@ def _build_tree(ws_context: context.WorkspaceContext) -> list[dict]:
 
         actions_nodes = _project_action_tree(ws_context.ws_projects.get(ws_dir), ws_context)
         node = {
-            "node_id": ws_dir.as_posix(),
+            "nodeId": ws_dir.as_posix(),
             "name": ws_dir.name,
             "subnodes": actions_nodes,
-            "node_type": dir_node_type,
+            "nodeType": dir_node_type,
             "status": status,
         }
         nodes.append(node)
@@ -149,10 +149,10 @@ def _build_tree(ws_context: context.WorkspaceContext) -> list[dict]:
             status = project.status.name if project is not None else ""
             actions_nodes = _project_action_tree(project, ws_context)
             node = {
-                "node_id": project_path.as_posix(),
+                "nodeId": project_path.as_posix(),
                 "name": project_path.name,
                 "subnodes": actions_nodes,
-                "node_type": 1,  # PROJECT
+                "nodeType": 1,  # PROJECT
                 "status": status,
             }
 

src/finecode/wm_server/wm_server.py

@@ -445,9 +445,9 @@ def _register_callbacks() -> None:
     async def on_project_changed(project: domain.Project) -> None:
         _notify_all_clients("actions/treeChanged", {
             "node": {
-                "node_id": str(project.dir_path),
+                "nodeId": str(project.dir_path),
                 "name": project.name,
-                "node_type": 1,
+                "nodeType": 1,
                 "status": project.status.name,
                 "subnodes": [],
             },