From dbfa7a3042b772cdd25d8d5e86a7e4c28bd039f7 Mon Sep 17 00:00:00 2001
From: Artem Muterko <artem@sopho.tech>
Date: Sun, 1 Mar 2026 13:42:12 +0100
Subject: [PATCH] Expand Lark provider test coverage

Add constructor validation tests (valid URL, invalid URL, empty URL),
payload field assertions, error severity handling, and server error
response test.

Signed-off-by: Ioannis Polyzos <ioannis@sophotech.io>
Signed-off-by: Artem Muterko <artem@sopho.tech>
---
 internal/notifier/lark_test.go | 87 ++++++++++++++++++++++++++++++++++
 1 file changed, 87 insertions(+)

diff --git a/internal/notifier/lark_test.go b/internal/notifier/lark_test.go
index b316c0500..d6ac8d5af 100644
--- a/internal/notifier/lark_test.go
+++ b/internal/notifier/lark_test.go
@@ -1,3 +1,19 @@
+/*
+Copyright 2020 The Flux authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
 package notifier
 
 import (
@@ -7,10 +23,34 @@ import (
 	"net/http"
 	"net/http/httptest"
 	"testing"
+	"time"
 
+	eventv1 "github.com/fluxcd/pkg/apis/event/v1beta1"
 	. "github.com/onsi/gomega"
 )
 
+func TestNewLark(t *testing.T) {
+	t.Run("valid URL", func(t *testing.T) {
+		g := NewWithT(t)
+		lark, err := NewLark("https://open.larksuite.com/open-apis/bot/v2/hook/test")
+		g.Expect(err).ToNot(HaveOccurred())
+		g.Expect(lark.URL).To(Equal("https://open.larksuite.com/open-apis/bot/v2/hook/test"))
+	})
+
+	t.Run("invalid URL", func(t *testing.T) {
+		g := NewWithT(t)
+		_, err := NewLark("not a url")
+		g.Expect(err).To(HaveOccurred())
+		g.Expect(err.Error()).To(ContainSubstring("invalid"))
+	})
+
+	t.Run("empty URL", func(t *testing.T) {
+		g := NewWithT(t)
+		_, err := NewLark("")
+		g.Expect(err).To(HaveOccurred())
+	})
+}
+
 func TestLark_Post(t *testing.T) {
 	g := NewWithT(t)
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -20,8 +60,16 @@ func TestLark_Post(t *testing.T) {
 		err = json.Unmarshal(b, &payload)
 		g.Expect(err).ToNot(HaveOccurred())
 
+		g.Expect(payload.MsgType).To(Equal("interactive"))
+		g.Expect(payload.Card.Config.WideScreenMode).To(BeTrue())
+		g.Expect(payload.Card.Header.Title.Tag).To(Equal("plain_text"))
 		g.Expect(payload.Card.Header.Title.Content).To(Equal("💫 gitrepository/webapp.gitops-system"))
 		g.Expect(payload.Card.Header.Template).To(Equal("turquoise"))
+		g.Expect(payload.Card.Elements).To(HaveLen(1))
+		g.Expect(payload.Card.Elements[0].Tag).To(Equal("div"))
+		g.Expect(payload.Card.Elements[0].Text.Tag).To(Equal("lark_md"))
+		g.Expect(payload.Card.Elements[0].Text.Content).To(ContainSubstring("message"))
+		g.Expect(payload.Card.Elements[0].Text.Content).To(ContainSubstring("test: metadata"))
 	}))
 	defer ts.Close()
 
@@ -31,3 +79,42 @@ func TestLark_Post(t *testing.T) {
 	err = lark.Post(context.TODO(), testEvent())
 	g.Expect(err).ToNot(HaveOccurred())
 }
+
+func TestLark_PostErrorSeverity(t *testing.T) {
+	g := NewWithT(t)
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		b, err := io.ReadAll(r.Body)
+		g.Expect(err).ToNot(HaveOccurred())
+		var payload LarkPayload
+		err = json.Unmarshal(b, &payload)
+		g.Expect(err).ToNot(HaveOccurred())
+
+		g.Expect(payload.Card.Header.Title.Content).To(HavePrefix("🚨"))
+		g.Expect(payload.Card.Header.Template).To(Equal("red"))
+	}))
+	defer ts.Close()
+
+	lark, err := NewLark(ts.URL)
+	g.Expect(err).ToNot(HaveOccurred())
+
+	event := testEvent()
+	event.Severity = eventv1.EventSeverityError
+	err = lark.Post(context.TODO(), event)
+	g.Expect(err).ToNot(HaveOccurred())
+}
+
+func TestLark_PostServerError(t *testing.T) {
+	g := NewWithT(t)
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.WriteHeader(http.StatusInternalServerError)
+	}))
+	defer ts.Close()
+
+	lark, err := NewLark(ts.URL)
+	g.Expect(err).ToNot(HaveOccurred())
+
+	ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
+	defer cancel()
+	err = lark.Post(ctx, testEvent())
+	g.Expect(err).To(HaveOccurred())
+}