Files with prefix `.` removed from the archive

[james-d-mitchell]

I used this action for (I think) the first time to release Semigroups v5.6.0:

https://github.com/semigroups/Semigroups/releases/tag/v5.6.0

and it seems that the files .VERSION and .LIBSEMIGROUPS_VERSION are not included in the archive:

semigroups/Semigroups#1143

Both of these files are in the git repo:

https://github.com/semigroups/Semigroups/blob/main/.LIBSEMIGROUPS_VERSION
https://github.com/semigroups/Semigroups/blob/main/.VERSION

I can't immediately see in either the release-pkg.,yml action of Semigroups:

https://github.com/semigroups/Semigroups/blob/main/.github/workflows/release-pkg.yml

or in this action where the files are deleted, and there's always the possibility that I am doing something wrong. Any hints for how to resolve this @stertooy @fingolfin ?

[stertooy]

release-pkg/action.yml

Line 142 in db30629

cp -r * "$RUNNER_TEMP/$BASENAME"

My guess is that the cp doesn't copy dotfiles because they aren't matched by the wildcard?

[james-d-mitchell]

Sounds reasonable, thanks for the super fast response @stertooy . Any idea how I can work around this issue until it can be resolved?

[stertooy]

I have a PR in that should fix this. As a workaround, I suppose you could temporarily switch the action to stertooy/release-pkg@also-copy-dotfiles until it's merged (or until we come up with another solution).

[james-d-mitchell]

Awesome thanks!

[dimpase]

It's a bit strange to me that the action doesn't try to create a tarball using make dist - which would be the normal way to create distributions of autotoolized projects.

[james-d-mitchell]

It's a bit strange to me that the action doesn't try to create a tarball using make dist - which would be the normal way to create distributions of autotoolized projects.

Good point but Semigroups isn't exactly autotoolized any more, and many GAP packages don't have a kernel extension, so don't even have a Makefile never mind make dist.

[limakzi]

@dimpase

First point is that the main idea of this action is that it helped to automate various processes needed to release a package.
As @james-d-mitchell noted - most of packages do not have any kernel extensions and do not require to build anything, and do not need Makefile at all.
Last but not least, I like the idea of passing the responsibility of building a tar-ball (especially, its content) on package maintainer instead of this action.

[dimpase]

OK, indeed, make dist is gone in Semigroups.

cp -r * "$RUNNER_TEMP/$BASENAME" 

How about replacing * with . above ?

[james-d-mitchell]

That's what @stertooy did exactly in his pr 😀