Skip to content

Commit d4e7586

Browse files
committed
test(django): Drop middleware_spans parametrize from test_active_thread_id
The arm only toggled creation of middleware spans, which this test never inspects: the streaming path skips non-segment spans, and the static path looks at profile and transaction items. Both DjangoIntegration(middleware_spans=) settings remain covered by the dedicated middleware-span tests.
1 parent f5c3a26 commit d4e7586

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

tests/integrations/django/asgi/test_asgi.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,6 @@ async def test_async_views(
199199

200200
@pytest.mark.parametrize("application", APPS)
201201
@pytest.mark.parametrize("endpoint", ["/sync/thread_ids", "/async/thread_ids"])
202-
@pytest.mark.parametrize("middleware_spans", [False, True])
203202
@pytest.mark.asyncio
204203
@pytest.mark.skipif(
205204
django.VERSION < (3, 1), reason="async views have been introduced in Django 3.1"
@@ -212,11 +211,10 @@ async def test_active_thread_id(
212211
teardown_profiling,
213212
endpoint,
214213
application,
215-
middleware_spans,
216214
span_streaming,
217215
):
218216
sentry_init(
219-
integrations=[DjangoIntegration(middleware_spans=middleware_spans)],
217+
integrations=[DjangoIntegration()],
220218
traces_sample_rate=1.0,
221219
profiles_sample_rate=1.0,
222220
trace_lifecycle="stream" if span_streaming else "static",

0 commit comments

Comments
 (0)