temp

Author: hvitved

rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll

@@ -268,12 +268,16 @@ private predicate isPanicMacroCall(MacroExpr me) {
   me.getMacroCall().resolveMacro().(MacroRules).getName().getText() = "panic"
 }
 
-private Type inferCertainStructExprType(StructExpr se, TypePath path) {
-  result = se.getPath().(TypeMention).getTypeAt(path)
-}
+/** Module for inferring certain type information. */
+module CertainTypeInference {
+  // todo: remove module wrapper
+  Type inferCertainStructExprType(StructExpr se, TypePath path) {
+    result = se.getPath().(TypeMention).getTypeAt(path)
+  }
 
-private Type inferCertainStructPatType(StructPat sp, TypePath path) {
-  result = sp.getPath().(TypeMention).getTypeAt(path)
+  Type inferCertainStructPatType(StructPat sp, TypePath path) {
+    result = sp.getPath().(TypeMention).getTypeAt(path)
+  }
 }
 
 private Type inferAssignmentOperationType(AstNode n, TypePath path) {
@@ -305,6 +309,7 @@ private Struct getRangeType(RangeExpr re) {
 
 pragma[nomagic]
 private TupleType inferTupleRootType(AstNode n) {
+  // `typeEquality` handles the non-root cases
   result.getArity() = [n.(TupleExpr).getNumberOfFields(), n.(TuplePat).getTupleArity()]
 }
 
@@ -386,6 +391,13 @@ private class NonAssocCallExpr extends CallExpr {
   }
 }
 
+/**
+ * Provides functionality related to context-based typing of calls.
+ */
+private module ContextTyping {
+  // todo: remove
+}
+
 /**
  * Holds if the type path `path` pointing to `type` is stripped of any leading
  * complex root type allowed for `self` parameters, such as `&`, `Box`, `Rc`,
@@ -1847,6 +1859,21 @@ private module AssocFunctionResolution {
   }
 }
 
+/**
+ * A matching configuration for resolving types of function call expressions
+ * like `foo.bar(baz)` and `Foo::bar(baz)`.
+ */
+private module FunctionCallMatchingInput {
+  // todo: remove
+}
+
+/**
+ * A matching configuration for resolving types of operations like `a + b`.
+ */
+private module OperationMatchingInput {
+  // todo: remove
+}
+
 pragma[nomagic]
 private Type getFieldExprLookupType(FieldExpr fe, string name, DerefChain derefChain) {
   exists(TypePath path |
@@ -2167,6 +2194,7 @@ private TupleType inferArgList(ArgList args, TypePath path) {
 
 cached
 private module Cached {
+  // todo: remove module wrapper
   /** Holds if `n` is implicitly dereferenced and/or borrowed. */
   cached
   predicate implicitDerefChainBorrow(Expr e, DerefChain derefChain, boolean borrow) {
@@ -2993,9 +3021,9 @@ private module Input3 implements InputSig3 {
     result = inferRefExprType(n) and
     path.isEmpty()
     or
-    result = inferCertainStructExprType(n, path)
+    result = CertainTypeInference::inferCertainStructExprType(n, path)
     or
-    result = inferCertainStructPatType(n, path)
+    result = CertainTypeInference::inferCertainStructPatType(n, path)
     or
     result = inferRangeExprType(n) and
     path.isEmpty()