Merge pull request #23 from mharmuth/feat/support-php84

Support PHP 8.4

Author: acoulton

.github/workflows/test.yml

@@ -18,6 +18,7 @@ jobs:
           - '8.1'
           - '8.2'
           - '8.3'
+          - '8.4'
         dependencies:
           - 'default'
         include:
@@ -29,6 +30,8 @@ jobs:
             dependencies: 'lowest'
           - php_version: '8.3'
             dependencies: 'lowest'
+          - php_version: '8.4'
+            dependencies: 'lowest'
     steps:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
@@ -44,7 +47,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(composer config cache-files-dir)"
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
           key: ${{ runner.os }}-composer-${{matrix.php_version}}-${{ matrix.dependencies }}-${{ hashFiles('**/composer.json') }}

CHANGELOG.md

@@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Unreleased
 
+## 1.3.2 / 2025-05-06
+
+* Support PHP 8.4 (thanks @mharmuth)
+
 ## 1.3.1 / 2024-09-03
 
 * Support PHP 8.3

composer.json

@@ -14,13 +14,13 @@
   "require": {
     "behat/gherkin": ">=2.0.0 <5.0.0",
     "masterminds/html5": "^2.7.5",
-    "php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
+    "php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
     "ext-dom": "*",
     "ext-SimpleXML": "*",
     "ext-libxml": "*"
   },
   "require-dev": {
-    "phpunit/phpunit": "^9.5",
+    "phpunit/phpunit": "^9.6.22",
     "behat/mink": "^1.7"
   },
   "suggest": {

src/AssertTable.php

@@ -30,10 +30,10 @@ class AssertTable
     protected $formatter;
 
     /**
-     * @param \Ingenerator\BehatTableAssert\TableDiffer\TableDiffer|NULL   $differ
-     * @param \Ingenerator\BehatTableAssert\TableDiffer\DiffFormatter|NULL $formatter
+     * @param \Ingenerator\BehatTableAssert\TableDiffer\TableDiffer|null   $differ
+     * @param \Ingenerator\BehatTableAssert\TableDiffer\DiffFormatter|null $formatter
      */
-    public function __construct(TableDiffer $differ = NULL, DiffFormatter $formatter = NULL)
+    public function __construct(?TableDiffer $differ = NULL, ?DiffFormatter $formatter = NULL)
     {
         $this->differ    = $differ ?: new TableDiffer;
         $this->formatter = $formatter ?: new DiffFormatter;

src/TableParser/CSV/CSVStreamTableParser.php

@@ -63,7 +63,7 @@ protected function isValidStream($string)
     protected function readCSVRows($stream)
     {
         $rows = [];
-        while ($row = \fgetcsv($stream)) {
+        while ($row = \fgetcsv($stream, 0, ',', '"', '\\')) {
             if ($row === [NULL]) {
                 $row = [];
             }