Building Jack 1.9.22 with Ubuntu 24.04 fails

[robiwano]

Describe the bug

Building JACK fails with waf due to Ubuntu 24.04 having Python 3.12 where imp has been deprecated in favor of importlib.

Environment

Version: 1.9.22
Operating system: Ubuntu 24.04
Installation: Source release package for 1.9.22

Steps To Reproduce

Download 1.9.22 package and unpack it. Run waf:

> ./waf --help
Traceback (most recent call last):
  File "/home/robi/build/test/aarch64/_deps/jack-lib/src/jack-lib/./waf", line 166, in <module>
    from waflib import Scripting
  File "/home/robi/build/test/aarch64/_deps/jack-lib/src/jack-lib/waflib/Scripting.py", line 10, in <module>
    from waflib import Utils, Configure, Logs, Options, ConfigSet, Context, Errors, Build, Node
  File "/home/robi/build/test/aarch64/_deps/jack-lib/src/jack-lib/waflib/Configure.py", line 16, in <module>
    from waflib import ConfigSet, Utils, Options, Logs, Context, Build, Errors
  File "/home/robi/build/test/aarch64/_deps/jack-lib/src/jack-lib/waflib/Options.py", line 14, in <module>
    from waflib import Logs, Utils, Context, Errors
  File "/home/robi/build/test/aarch64/_deps/jack-lib/src/jack-lib/waflib/Context.py", line 9, in <module>
    import os, re, imp, sys
ModuleNotFoundError: No module named 'imp'

[ax562]

The issue was "import imp" in "Configure.py". "imp" is deprecated and is not working in recent python3 versions.

FIX:
replace lines in "waflib/Configure.py"-
"import os, re, imp, sys" with "import os, re, types, sys"
"module = imp.new_module(WSCRIPT_FILE)" with "module = types.ModuleType(name=WSCRIPT_FILE)"

[keithbowes]

Was that fixed by 2504203?

[hugobuddel]

Python 3.12 support seems to be fixed now indeed. Maybe it is time for a new release? Python 3.11 will be end of life at the end of October.