return the status of packages and ignore hidden ones (fix #113)

this is an enhancement for users managing private repositories with
Update Retriever, which can mark packages as 'Active' (default),
'Hidden' or some other statuses. This status was previously ignored.

Packages sourced from Model-XML repositories, including Lenovos
public repository, do not store Status information for packages.

Author: jantari

LSUClient.psm1

@@ -113,6 +113,7 @@ class PackageFilePointer {
 # Internal
 class PackageXmlPointer : PackageFilePointer {
     [string] $Category
+    [string] $Status
 
     # Constructor with file name
     PackageXmlPointer (
@@ -122,7 +123,8 @@ class PackageXmlPointer : PackageFilePointer {
         [string] $Kind,
         [string] $Checksum,
         [Int64] $Size,
-        [string] $Category
+        [string] $Category,
+        [string] $Status
     ) : base (
         $Name,
         $AbsoluteLocation,
@@ -132,6 +134,7 @@ class PackageXmlPointer : PackageFilePointer {
         $Size
     ) {
         $this.Category = $Category
+        $this.Status = $Status
     }
 
     # Constructor without explicit file name
@@ -141,7 +144,8 @@ class PackageXmlPointer : PackageFilePointer {
         [string] $Kind,
         [string] $Checksum,
         [Int64] $Size,
-        [string] $Category
+        [string] $Category,
+        [string] $Status
     ) : base (
         $AbsoluteLocation,
         $LocationType,
@@ -150,6 +154,7 @@ class PackageXmlPointer : PackageFilePointer {
         $Size
     ) {
         $this.Category = $Category
+        $this.Status = $Status
     }
 }
 
@@ -172,6 +177,7 @@ class LenovoPackage {
     [Severity] $Severity
     [DateTime] $ReleaseDate
     [int] $RebootType
+    [string] $Status
     [string] $Vendor
     [Int64] $Size
     [string] $URL

private/Get-PackagesInRepository.ps1

@@ -65,7 +65,8 @@
                     'XmlDefinition',
                     $Package.checksum.'#text',
                     0,
-                    $Package.category
+                    $Package.category,
+                    'Active' # Model-XML files do not store a status for packages, so I've decided to default them all to 'Active' for usability
                 )
             } else {
                 Write-Error "The package definition at $($Package.location) could not be found or accessed"
@@ -99,18 +100,25 @@
         :NextPackage foreach ($Package in $PARSEDXML.Database.package) {
             foreach ($CompatibleSystem in $Package.SystemCompatibility.System) {
                 if ($CompatibleSystem.mtm -eq $Model -and $CompatibleSystem.os -eq "Windows $($CachedHardwareTable._OS)") {
-                    $PathInfo = Get-PackagePathInfo -Path $Package.LocalPath -BasePath $Repository
-                    if ($PathInfo.Valid) {
-                        [PackageXmlPointer]::new(
-                            $PathInfo.AbsoluteLocation,
-                            $PathInfo.Type,
-                            'XmlDefinition',
-                            $Package.checksum.'#text',
-                            0,
-                            $Package.category
-                        )
+                    # Updates in a database.xml repository have a 'Status' that can be set to 'Active', 'Hidden' and a few others.
+                    # Get-LSUpdate should not show updates that have been hidden, so we skip them. See issue #113.
+                    if ($Package.Status -ne 'Hidden') {
+                        $PathInfo = Get-PackagePathInfo -Path $Package.LocalPath -BasePath $Repository
+                        if ($PathInfo.Valid) {
+                            [PackageXmlPointer]::new(
+                                $PathInfo.AbsoluteLocation,
+                                $PathInfo.Type,
+                                'XmlDefinition',
+                                $Package.checksum.'#text',
+                                0,
+                                $Package.category,
+                                $Package.Status
+                            )
+                        } else {
+                            Write-Error "The package definition at $($Package.LocalPath) could not be found or accessed"
+                        }
                     } else {
-                        Write-Error "The package definition at $($Package.LocalPath) could not be found or accessed"
+                        Write-Verbose "Discovered package $($Package.LocalPath) is hidden and will be ignored"
                     }
                     continue NextPackage
                 }

public/Get-LSUpdate.ps1

@@ -294,6 +294,7 @@
                 'Severity'     = $PackageSeverity
                 'ReleaseDate'  = [DateTime]::ParseExact($packageXML.Package.ReleaseDate, 'yyyy-MM-dd', [CultureInfo]::InvariantCulture, 'None')
                 'RebootType'   = $packageXML.Package.Reboot.type
+                'Status'       = $Package.Status
                 'Vendor'       = $packageXML.Package.Vendor
                 'Size'         = $PackageSize
                 'URL'          = $Package.AbsoluteLocation