Provider & embeddings intra-file sync/async duplication (Gemini, Anthropic, embeddings)

[johnnichev]

Provider & embeddings intra-file duplication

Not cross-provider (wire protocols differ — the one shareable family already lives in _openai_compat.py). The duplication is within each file, between sync and async paths.

Gemini (src/selectools/gemini_provider.py): the HttpOptions + GenerateContentConfig + tools block is repeated ×4 (177-188, 300-311, 573-584, 692-703); the function_call → ToolCall conversion (with base64 thought_signature) ×4 (217, 365, 613, 752). A comment at :633 even says "see complete() for context." Densest in the providers.

Anthropic (src/selectools/anthropic_provider.py): request_args dict ×4 (189-200, 275-286, 565-576, 651-662); content-block parse loop ×2; usage-extraction ×2; streaming event state-machine ×2 (sync/async, identical but for for/async for).

Embeddings (M6): _get_model_dimension (substring-match + warning fallback) ×4 (openai/anthropic/cohere/gemini); the trivial dimension property re-declared ×4 only for a docstring → pull into the EmbeddingProvider ABC; anthropic+cohere share an identical except TypeError: older-client fallback.

Fix

Per-file private helpers (_build_config/_toolcall_from_part for Gemini; _build_request_args/_usage_from_response/_message_from_content_blocks for Anthropic). Pull the embeddings dimension property into the ABC. Do NOT build a cross-provider build_usage — the three cache-token field shapes make it ugly.

Acceptance

• Sync/async paths in each provider share the extracted helper; provider tests pass.

[vaishnavidesai09]

Hi @johnnichev,

I'd like to work on this issue. I can refactor the duplicated sync/async logic within the Gemini and Anthropic providers into private helpers, and consolidate the shared embeddings dimension logic into the embedding provider base class while preserving existing behavior and test coverage.

Please assign it to me if it's available. Thanks!

[johnnichev]

That sounds good! Thank you for tackling this issue, just assigned to you! @vaishnavidesai09

[johnnichev]

PR #153 (@vaishnavidesai09) is in flight against this, covering the Gemini and Anthropic helper extractions plus the embeddings dimension pull-up into the ABC. Currently CHANGES_REQUESTED: one behavior regression to fix (dropped _yielded_any = True in the Gemini stream paths, which trips the #66 empty-response guard) and CI lint/format failures. Leaving this issue open until that lands.