update list and get repo cmds to match updated API response (#672)

Author: sami-alajrami

cmd/kosli/getRepo.go

@@ -107,17 +107,15 @@ func (o *getRepoOptions) run(out io.Writer, args []string) error {
 
 func printRepoAsTable(raw string, out io.Writer, page int) error {
 	var response struct {
-		Embedded struct {
-			Repos []map[string]any `json:"repos"`
-		} `json:"_embedded"`
+		Repos []map[string]any `json:"repos"`
 	}
 
 	err := json.Unmarshal([]byte(raw), &response)
 	if err != nil {
 		return err
 	}
 
-	repos := response.Embedded.Repos
+	repos := response.Repos
 	if len(repos) == 0 {
 		logger.Info("Repo was not found.")
 		return nil

cmd/kosli/getRepo_test.go

@@ -60,7 +60,7 @@ func (suite *GetRepoCommandTestSuite) TestGetRepoCmd() {
 		{
 			name:       "03-getting an existing repo with --output json works",
 			cmd:        fmt.Sprintf(`get repo kosli-dev/cli --output json %s`, suite.acmeOrgKosliArguments),
-			goldenJson: []jsonCheck{{"_embedded.repos", "non-empty"}},
+			goldenJson: []jsonCheck{{"repos", "non-empty"}},
 		},
 		{
 			name: "04-getting an existing repo with matching --provider works",
@@ -69,7 +69,7 @@ func (suite *GetRepoCommandTestSuite) TestGetRepoCmd() {
 		{
 			name:       "05-getting an existing repo with matching --provider and --output json works",
 			cmd:        fmt.Sprintf(`get repo kosli-dev/cli --provider github --output json %s`, suite.acmeOrgKosliArguments),
-			goldenJson: []jsonCheck{{"_embedded.repos", "non-empty"}},
+			goldenJson: []jsonCheck{{"repos", "non-empty"}},
 		},
 		{
 			name:   "06-getting a repo with a non-matching --provider returns not-found message",

cmd/kosli/listRepos.go

@@ -84,16 +84,14 @@ func (o *listReposOptions) run(out io.Writer) error {
 func printReposListAsTable(raw string, out io.Writer, page int) error {
 	var repos []map[string]any
 	var response struct {
-		Embedded struct {
-			Repos []map[string]any `json:"repos"`
-		} `json:"_embedded"`
+		Repos []map[string]any `json:"repos"`
 	}
 
 	err := json.Unmarshal([]byte(raw), &response)
 	if err != nil {
 		return err
 	}
-	repos = response.Embedded.Repos
+	repos = response.Repos
 
 	if len(repos) == 0 {
 		logger.Info("No repos were found.")

cmd/kosli/listRepos_test.go

@@ -62,13 +62,13 @@ func (suite *ListReposCommandTestSuite) TestListReposCmd() {
 		{
 			name:       "03-listing repos with --output json works when there are repos",
 			cmd:        fmt.Sprintf(`list repos --output json %s`, suite.acmeOrgKosliArguments),
-			goldenJson: []jsonCheck{{"_embedded.repos", "non-empty"}},
+			goldenJson: []jsonCheck{{"repos", "non-empty"}},
 		},
 		// THIS TEST IS FLAKY IN CI SINCE CI VARIABLES ARE SET THERE AND REPOS MAY EXIST FROM OTHER TESTS
 		// {
 		// 	name:       "04-listing repos with --output json works when there are no repos",
 		// 	cmd:        fmt.Sprintf(`list repos --output json %s`, suite.defaultKosliArguments),
-		// 	goldenJson: []jsonCheck{{"_embedded.repos", "[]"}},
+		// 	goldenJson: []jsonCheck{{"repos", "[]"}},
 		// },
 		{
 			wantError: true,
@@ -101,7 +101,7 @@ func (suite *ListReposCommandTestSuite) TestListReposCmd() {
 		{
 			name:       "10-listing repos with --name filter and --output json works",
 			cmd:        fmt.Sprintf(`list repos --name kosli-dev/cli --output json %s`, suite.acmeOrgKosliArguments),
-			goldenJson: []jsonCheck{{"_embedded.repos", "non-empty"}},
+			goldenJson: []jsonCheck{{"repos", "non-empty"}},
 		},
 		{
 			name:        "11-listing repos with --provider filter works",