Skip to content

Commit 8770569

Browse files
committed
Graduate WorkloadRequestUseMergePatch to Beta.
1 parent 5f59467 commit 8770569

File tree

5 files changed

+7
-32
lines changed

5 files changed

+7
-32
lines changed

pkg/features/kube_features.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,7 @@ var defaultVersionedFeatureGates = map[featuregate.Feature]featuregate.Versioned
338338
},
339339
WorkloadRequestUseMergePatch: {
340340
{Version: version.MustParse("0.14"), Default: false, PreRelease: featuregate.Alpha},
341+
{Version: version.MustParse("0.16"), Default: true, PreRelease: featuregate.Beta},
341342
},
342343
SanitizePodSets: {
343344
{Version: version.MustParse("0.13"), Default: true, PreRelease: featuregate.Beta},

site/content/en/docs/concepts/multikueue.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ Known Limitation:
108108
{{% alert title="Warning" color="primary" %}}
109109
For the external controller to patch the `.status.nominatedClusterNames` field there are 2 options:
110110
* Use the `kueue-admission` field manager, because the kueue-admission field manager is responsible for managing updates to the `.status.nominatedClusterNames` field.
111-
* [Enable `WorkloadRequestUseMergePatch` feature gate](docs/concepts/workload#workload-updates-by-kueue) that drops the `kueue-admission` field manager from the `.status.nominatedClusterNames`.
112111

113112
Without this, the Kueue is not able to admit the MultiKueue workloads.
114113
{{% /alert %}}

site/content/en/docs/concepts/workload.md

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -170,34 +170,7 @@ Once deactivated, the accumulated time spent as active in previous "Admit/Evict"
170170

171171
If `maximumExecutionTimeSeconds` is not specified, the workload has no execution time limit.
172172

173-
You can configure the `maximumExecutionTimeSeconds` of the Workload associated with any supported Kueue Job by specifying the desired value as `kueue.x-k8s.io/max-exec-time-seconds` label of the job.
174-
175-
## Workload updates by Kueue
176-
177-
{{< feature-state state="alpha" for_version="v0.14" >}}
178-
179-
{{% alert title="Note" color="primary" %}}
180-
`WorkloadRequestUseMergePatch` is currently an alpha feature and is disabled by default.
181-
182-
You can enable it by editing the `WorkloadRequestUseMergePatch` feature gate. Refer to the
183-
[Installation guide](/docs/installation/#change-the-feature-gates-configuration)
184-
for instructions on configuring feature gates.
185-
{{% /alert %}}
186-
187-
188-
By default Workload status updates are performed by Kueue using the [Server-Side Apply (SSA)](https://kubernetes.io/docs/reference/using-api/server-side-apply/).
189-
190-
However due to the limitations of SSA ([missing support for duplicated key/value pairs](https://github.com/kubernetes/kubernetes/issues/113482)) we also offer to enable updating the Workload status
191-
with Merge Patches, by enabling the `WorkloadRequestUseMergePatch` feature gate.
192-
193-
In particular, this allows users of Kueue to handle the following two issues:
194-
- [Add option to disable strict pod spec validation](https://github.com/kubernetes-sigs/kueue/issues/3540)
195-
Switching from ServerSideApply to Merge Patch allows partial updates without requiring the entire resource specification.
196-
This can bypass the strict validation rules causing issues with duplicated environment variables, aligning Kueue's behavior more closely with plain Kubernetes
197-
- [MultiKueue: remove the limitation that the external dispatches need to use kueue-admission field manager ](https://github.com/kubernetes-sigs/kueue/issues/6185)
198-
Using ServerSideApply blocked the ability for Workload Status to be modified from external controllers.
199-
Once the field e.g. `.status.nominatedClusterNames` was modified and owned by the controller (regardless if Kueue or external one) it can not be modified or cleared by the other.
200-
This effectively prevent External Dispatching mechanism to work properly in multi cluster enviroment.
173+
You can configure the `maximumExecutionTimeSeconds` of the Workload associated with any supported Kueue Job by specifying the desired value as `kueue.x-k8s.io/max-exec-time-seconds` label of the job.
201174

202175
## What's next
203176

site/content/en/docs/installation/_index.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ spec:
281281
### Feature gates for alpha and beta features
282282

283283
| Feature | Default | Stage | Since | Until |
284-
| --------------------------------------------- | ------- | ----- | ----- | ----- |
284+
| --------------------------------------------- |---------| ----- | ----- | ----- |
285285
| `FlavorFungibility` | `true` | Beta | 0.5 | |
286286
| `MultiKueue` | `false` | Alpha | 0.6 | 0.8 |
287287
| `MultiKueue` | `true` | Beta | 0.9 | |
@@ -314,7 +314,8 @@ spec:
314314
| `ManagedJobsNamespaceSelectorAlwaysRespected` | `false` | Alpha | 0.13 | 0.15 |
315315
| `ManagedJobsNamespaceSelectorAlwaysRespected` | `true` | Beta | 0.15 | |
316316
| `FlavorFungibilityImplicitPreferenceDefault` | `false` | Alpha | 0.13 | 0.16 |
317-
| `WorkloadRequestUseMergePatch` | `false` | Alpha | 0.14 | |
317+
| `WorkloadRequestUseMergePatch` | `false` | Alpha | 0.14 | 0.15 |
318+
| `WorkloadRequestUseMergePatch` | `true` | Beta | 0.16 | |
318319
| `SanitizePodSets` | `true` | Beta | 0.13 | |
319320
| `MultiKueueAllowInsecureKubeconfigs` | `false` | Alpha | 0.13 | |
320321
| `ReclaimablePods` | `true` | Beta | 0.15 | |

site/content/zh-CN/docs/installation/_index.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,8 @@ spec:
294294
| `ElasticJobsViaWorkloadSlices` | `false` | Alpha | 0.13 | |
295295
| `ManagedJobsNamespaceSelectorAlwaysRespected` | `false` | Alpha | 0.13 | |
296296
| `FlavorFungibilityImplicitPreferenceDefault` | `false` | Alpha | 0.13 | 0.16 |
297-
| `WorkloadRequestUseMergePatch` | `false` | Alpha | 0.14 | |
297+
| `WorkloadRequestUseMergePatch` | `false` | Alpha | 0.14 | 0.15 |
298+
| `WorkloadRequestUseMergePatch` | `true` | Beta | 0.16 | |
298299
| `SanitizePodSets` | `true` | Beta | 0.13 | |
299300
| `MultiKueueAllowInsecureKubeconfigs` | `false` | Alpha | 0.13 | |
300301

0 commit comments

Comments
 (0)