Skip to content

Conversation

@HirazawaUi
Copy link
Contributor

Description

This is a follow-up to the review comments on PR #52876. Due to the approaching docs freeze, we did not have time to address these comments earlier, and we will resolve these outstanding comments in this PR.

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.35 milestone Dec 5, 2025
@netlify
Copy link

netlify bot commented Dec 5, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit db77334
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/693814b2d2a90a0007bc3581

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dipesh-rawat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 5, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2025
@HirazawaUi
Copy link
Contributor Author

/cc @lmktfy

@k8s-ci-robot k8s-ci-robot requested a review from lmktfy December 5, 2025 12:27
@netlify
Copy link

netlify bot commented Dec 5, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit db77334
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/693814b26bf4d0000830f5c0
😎 Deploy Preview https://deploy-preview-53517--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

When disabled, kubelet restarts will not change the status of Pods already running on the node,
This Feature Gate was introduced to allow revert the behavior to previously used default.
Enable legacy writes to update container `ready` status after the kubelet detects a
[restart](docs/concepts/workloads/pods/pod-lifecycle/#kubelet-restarts).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is broken it's missing a starting / and points to a section that does not exist on the page.
I have added a suggestion below for what I think it should be.

Suggested change
[restart](docs/concepts/workloads/pods/pod-lifecycle/#kubelet-restarts).
[restart](/docs/concepts/workloads/pods/pod-lifecycle/#restart-policy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants