Skip to content

Conversation

@wirekang
Copy link

@wirekang wirekang commented Dec 9, 2025

Description

1. Replace some unsupported images to official images

radial/busyboxplus:curl -> curlimages/curl or busybox depends on context.
bprashanth/nginxhttps -> nginx.

2. Decouple from archived example

The example is archived and no longer maintained. I removed references to archived example by embedding a few files into tutorial directly:

default.conf into code sample.
One-liner Makefile into code snippet.

Issue

Closes: #33169, #52702

@k8s-ci-robot
Copy link
Contributor

Welcome @wirekang!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sayakmukhopadhyay for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 9, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 9, 2025
@netlify
Copy link

netlify bot commented Dec 9, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cc95067
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/69378847ffd703000866cb30
😎 Deploy Preview https://deploy-preview-53553--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@wirekang
Copy link
Author

wirekang commented Dec 9, 2025

For reviewers: link to deploy preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CN missmatch in Securing nginx example

2 participants