add types for _ffi_names in RemoteCollection

Author: BenediktSeidl

pygit2/remotes.py

@@ -46,7 +46,7 @@
 
 # Need BaseRepository for type hints, but don't let it cause a circular dependency
 if TYPE_CHECKING:
-    from ._libgit2.ffi import GitRemoteC
+    from ._libgit2.ffi import GitRemoteC, char_pointer
     from .repository import BaseRepository
 
 
@@ -367,12 +367,12 @@ def __getitem__(self, name: str | int) -> Remote:
 
         return Remote(self._repo, cremote[0])
 
-    def _ffi_names(self):
+    def _ffi_names(self) -> Generator['char_pointer', None, None]:
         with utils.new_git_strarray() as names:
             err = C.git_remote_list(names, self._repo._repo)
             check_error(err)
             for i in range(names.count):
-                yield names.strings[i]
+                yield names.strings[i]  # type: ignore[index]
 
     def names(self) -> Generator[str | None, None, None]:
         """An iterator over the names of the available remotes."""

pygit2/utils.py

@@ -29,6 +29,7 @@
 from typing import (
     TYPE_CHECKING,
     Generic,
+    Generator,
     Iterator,
     Optional,
     Protocol,
@@ -45,7 +46,7 @@
     from ._libgit2.ffi import ArrayC, GitStrrayC, char, char_pointer
 
 
-def maybe_string(ptr: 'char_pointer') -> str | None:
+def maybe_string(ptr: 'char_pointer' | None) -> str | None:
     if not ptr:
         return None
 
@@ -105,7 +106,7 @@ def ptr_to_bytes(ptr_cdata):
 
 
 @contextlib.contextmanager
-def new_git_strarray():
+def new_git_strarray() -> Generator[GitStrrayC, None, None]:
     strarray = ffi.new('git_strarray *')
     yield strarray
     C.git_strarray_dispose(strarray)