Skip to content

Conversation

@VolodymyrBg
Copy link
Contributor

The error context in MessagesSerializer::serialize() used "MessagesHandler" when mapping the error for message type ID serialization. This was inconsistent with the rest of the method, where "MessagesSerializer" is correctly used, and with
the convention in MessagesHandler::handle().

Using the correct component label improves log consistency, diagnostics, and filtering. No functional behavior changes; this is a logging/diagnostic fix.

Copy link
Contributor

@bilboquet bilboquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@bilboquet bilboquet enabled auto-merge November 12, 2025 09:09
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.51%. Comparing base (c37d88d) to head (bf49e8a).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
massa-protocol-worker/src/messages.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4948      +/-   ##
==========================================
- Coverage   71.78%   71.51%   -0.27%     
==========================================
  Files         291      288       -3     
  Lines       51642    50351    -1291     
==========================================
- Hits        37069    36010    -1059     
+ Misses      14573    14341     -232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bilboquet bilboquet added this pull request to the merge queue Nov 12, 2025
Merged via the queue into massalabs:main with commit 6d13993 Nov 12, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants