fix: only skip offset

joakimfors · megastep · commit 51e729920a6f · 2025-09-26T13:12:03.000-07:00
The dd option skip seeks the input stream. An additional count reads the
specified bytes from the input and outputs it. This causes the last bytes
read to be incorrect.
diff --git a/makeself-header.sh b/makeself-header.sh
@@ -130,7 +130,7 @@ MS_dd_Progress()
     blocks=\`expr \$length / \$bsize\`
     bytes=\`expr \$length % \$bsize\`
     (
-        dd ibs=\$offset skip=1 count=1 2>/dev/null
+        dd ibs=\$offset skip=1 count=0 2>/dev/null
         pos=\`expr \$pos \+ \$bsize\`
         MS_Printf "     0%% " 1>&2
         if test \$blocks -gt 0; then

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ MS_dd_Progress()`
`130`	`130`	blocks=\`expr \$length / \$bsize\`
`131`	`131`	bytes=\`expr \$length % \$bsize\`
`132`	`132`	`(`
`133`		`- dd ibs=\$offset skip=1 count=1 2>/dev/null`
	`133`	`+ dd ibs=\$offset skip=1 count=0 2>/dev/null`
`134`	`134`	pos=\`expr \$pos \+ \$bsize\`
`135`	`135`	`MS_Printf " 0%% " 1>&2`
`136`	`136`	`if test \$blocks -gt 0; then`