Skip to content

Commit cc01642

Browse files
Mark Landismegastep
authored andcommitted
Remove negative test
The negative test was written assuming gzip implementations would return an error code when invalid command line options were used. This is not always the case: BSD variants of gzip (e.g., FreeBSD, Apple) return success even when an invalid option is specified. Since this is out of the control of makeself, and behaviors will differ widely among the various supported compressors and platforms, it doesn't make sense to maintain this test. The same behavior is theoretically possible with 'tar' implementations and the --tar-extra flag.
1 parent 84c63ed commit cc01642

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

test/compextratest

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,6 @@ testCompExtraOpts() {
2727
tearDown
2828
}
2929

30-
# Negative test: ensure failures are detected when invalid compressor
31-
# extras are specified.
32-
testCompExtraOptsInvalid() {
33-
setupTests
34-
35-
comp_extra="-x" # -x is an invalid gzip option
36-
${SUT} --comp-extra "$comp_extra" src src.sh alabel startup.sh
37-
38-
assertNotEquals $? 0
39-
40-
tearDown
41-
}
42-
43-
4430
# Load and run shUnit2.
4531
source "./shunit2/shunit2"
4632

0 commit comments

Comments
 (0)