Fix #349: pre-extraction script execution in combination with --notemp #350
Conversation
vladermolaev
commented
Oct 15, 2025
vladermolaev
commented
- MS_Preextract creates temp script in $location rather than $tmpdir
- New test case to verify the fix in test/preextracttest
|
Afraid this breaks other tests... |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #349 where pre-extraction scripts would fail when using the --notemp flag. The fix ensures that the pre-extraction script executes in $location (the extraction directory) instead of $tmpdir (which doesn't exist when --notemp is used). A new test case validates that pre-extraction scripts work correctly with the --notemp flag.
- Changed pre-extraction script execution directory from
$tmpdirto$location - Added test case
testPreextractNotempto verify pre-extraction scripts work with--notemp
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| makeself-header.sh | Changed pre-extraction script execution to use $location instead of $tmpdir |
| test/preextracttest | Added test case to verify pre-extraction scripts work with --notemp flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vladermolaev
force-pushed
the
master
branch
3 times, most recently
from
ea21f45 to
6e476fb
Compare
… --notemp - MS_Preextract uses basename of pre-extraction script to run it - New test case to verify the fix in test/preextracttest
|
Please review. All tests are green now. |
|
OK, the NetBSD test fails but I think that's unrelated (been broken for a while). I'll merge, thanks! |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
makeself-header.sh:1
- The prescript is created in
$location(line 327) but executed from$tmpdir(line 331). If these directories differ (as with --notemp), the script won't be found at./\$prescript_basename. The script should either be created in$tmpdiror the execution should reference the correct directory.
cat << EOF > "$archname"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2 participants
