From 952b85196f3fae5d846c1c135cb6c495f74dfdde Mon Sep 17 00:00:00 2001 From: "Charan sai Uggam (Accenture International Limited)" Date: Tue, 1 Apr 2025 15:52:49 +0530 Subject: [PATCH 1/3] CodeQL bug fix --- src/service/API/Startup.cs | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/service/API/Startup.cs b/src/service/API/Startup.cs index 8eda5a8..63737b2 100644 --- a/src/service/API/Startup.cs +++ b/src/service/API/Startup.cs @@ -58,16 +58,15 @@ public void ConfigureServices(IServiceCollection services) /// Configures the HTTP pipeline /// public void Configure(IApplicationBuilder app, IWebHostEnvironment env) - { - app.UseSwagger(); - app.UseSwaggerUI(c => - { - c.SwaggerEndpoint("/swagger/v1/swagger.json", "Flighting Service V2"); - c.RoutePrefix = string.Empty; - }); - + { if (env.IsDevelopment()) { + app.UseSwagger(); + app.UseSwaggerUI(c => + { + c.SwaggerEndpoint("/swagger/v1/swagger.json", "Flighting Service V2"); + c.RoutePrefix = string.Empty; + }); app.UseDeveloperExceptionPage(); } else From 3c85a5039923e451994b72faa84ff345320c69dd Mon Sep 17 00:00:00 2001 From: "Charan sai Uggam (Accenture International Limited)" Date: Thu, 3 Apr 2025 15:06:10 +0530 Subject: [PATCH 2/3] Upgraded to 6 to fix pipeline build issue --- .github/workflows/ci.yml | 8 ++++---- .../Microsoft.FeatureFlighting.Tests.Functional.csproj | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cf159d2..0adf3ce 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,10 +14,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Setup .NET 3.1.x - uses: actions/setup-dotnet@v1 - with: - dotnet-version: 3.1.x + # - name: Setup .NET 3.1.x + # uses: actions/setup-dotnet@v1 + # with: + # dotnet-version: 3.1.x - name: Setup .NET 6.x uses: actions/setup-dotnet@v1 diff --git a/tests/functional/Tests/Microsoft.FeatureFlighting.Tests.Functional.csproj b/tests/functional/Tests/Microsoft.FeatureFlighting.Tests.Functional.csproj index 6e9e6a7..51a679b 100644 --- a/tests/functional/Tests/Microsoft.FeatureFlighting.Tests.Functional.csproj +++ b/tests/functional/Tests/Microsoft.FeatureFlighting.Tests.Functional.csproj @@ -1,7 +1,7 @@ - netcoreapp3.1 + net6.0 Preview false From 77f805175b4b420b4622154492e5ce99fed28e61 Mon Sep 17 00:00:00 2001 From: "Charan sai Uggam (Accenture International Limited)" Date: Thu, 3 Apr 2025 15:37:18 +0530 Subject: [PATCH 3/3] Changes Reverted --- .github/workflows/ci.yml | 8 ++++---- .../Microsoft.FeatureFlighting.Tests.Functional.csproj | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0adf3ce..cf159d2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,10 +14,10 @@ jobs: steps: - uses: actions/checkout@v2 - # - name: Setup .NET 3.1.x - # uses: actions/setup-dotnet@v1 - # with: - # dotnet-version: 3.1.x + - name: Setup .NET 3.1.x + uses: actions/setup-dotnet@v1 + with: + dotnet-version: 3.1.x - name: Setup .NET 6.x uses: actions/setup-dotnet@v1 diff --git a/tests/functional/Tests/Microsoft.FeatureFlighting.Tests.Functional.csproj b/tests/functional/Tests/Microsoft.FeatureFlighting.Tests.Functional.csproj index 51a679b..6e9e6a7 100644 --- a/tests/functional/Tests/Microsoft.FeatureFlighting.Tests.Functional.csproj +++ b/tests/functional/Tests/Microsoft.FeatureFlighting.Tests.Functional.csproj @@ -1,7 +1,7 @@ - net6.0 + netcoreapp3.1 Preview false