Fix telemetry failure for long-running sessions#228
Open
HowardWolosky wants to merge 2 commits intomicrosoft:masterfrom
Open
Fix telemetry failure for long-running sessions#228HowardWolosky wants to merge 2 commits intomicrosoft:masterfrom
HowardWolosky wants to merge 2 commits intomicrosoft:masterfrom
Conversation
The telemetry code was creating a singleton base telemetry event the first time that telemetry was being sent. That base event included the date. If a PowerShell session lasted multiple days, the telemetry reporting would eventually start to fail because the date being reported for the event was too old. We now just create a new telemetry event every time one is requested (this also ensures that it honors changes to the `ApplicationInsightsKey`), and now we only cache a GUID that we use to represent the "session" ID which we consider to be the duration of the current PowerShell session.
… telemetry more than once per session. Use a flag to mimic that now.
joseartrivera
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The telemetry code was creating a singleton base telemetry event the first time that telemetry was being sent. That base event included the date. If a PowerShell session lasted multiple days, the telemetry reporting would eventually start to fail because the date being reported for the event was too old.
We now just create a new telemetry event every time one is requested (this also ensures that it honors changes to the
ApplicationInsightsKey), and now we only cache a GUID that we use to represent the "session" ID which we consider to be the duration of the current PowerShell session.