Change default value for rename symbol suggestions #2482
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the default value for the chat.inlineEdits.renameSymbolSuggestions configuration setting from false to true, removing the team-specific default value structure that was previously in place. This change graduates the rename symbol suggestions feature from team testing (where it was enabled via teamDefaultValue: true) to general availability with a standard default of true.
Key Changes:
- Changed the configuration definition from using a
CustomTeamDefaultValueobject withdefaultValue: falseandteamDefaultValue: trueto a simple boolean default oftrue - Removed the owner (
benibenj) and expiration date (2025-12-10) fields that were part of the team default structure
| export const InlineEditsNextCursorPredictionDisplayLine = defineAndMigrateExpSetting<boolean>('chat.advanced.inlineEdits.nextCursorPrediction.displayLine', 'chat.inlineEdits.nextCursorPrediction.displayLine', true); | ||
| export const InlineEditsNextCursorPredictionCurrentFileMaxTokens = defineAndMigrateExpSetting<number>('chat.advanced.inlineEdits.nextCursorPrediction.currentFileMaxTokens', 'chat.inlineEdits.nextCursorPrediction.currentFileMaxTokens', xtabPromptOptions.DEFAULT_OPTIONS.currentFile.maxTokens); | ||
| export const InlineEditsRenameSymbolSuggestions = defineSetting<boolean>('chat.inlineEdits.renameSymbolSuggestions', ConfigType.ExperimentBased, { defaultValue: false, teamDefaultValue: true, owner: 'benibenj', expirationDate: '2025-12-10' }); | ||
| export const InlineEditsRenameSymbolSuggestions = defineSetting<boolean>('chat.inlineEdits.renameSymbolSuggestions', ConfigType.ExperimentBased, true); |
There was a problem hiding this comment.
The default value in the code has been changed to true, but the corresponding default value in package.json (line 3875) is still false. This mismatch will cause a BugIndicatingError to be thrown at runtime with the message "The default value for setting chat.inlineEdits.renameSymbolSuggestions is different in packageJson and in code".
The validation logic in toBaseConfig (lines 456-458) ensures that default values match between the code and package.json for public settings. You must also update the default value in package.json to true to match this change.
Copilot Generated Description:Update the default setting value for rename symbol suggestions to true.