Merge remote-tracking branch 'origin/main' into tyriar/gpu_report

Author: Tyriar

.eslint-plugin-local/code-no-redundant-has-before-delete.ts

@@ -57,17 +57,7 @@ src/vs/editor/contrib/suggest/** @jrieken
 src/vs/editor/contrib/format/** @jrieken
 
 # Bootstrap
-src/bootstrap-cli.ts @bpasero
-src/bootstrap-esm.ts @bpasero
-src/bootstrap-fork.ts @bpasero
-src/bootstrap-import.ts @bpasero
-src/bootstrap-meta.ts @bpasero
-src/bootstrap-node.ts @bpasero
-src/bootstrap-server.ts @bpasero
-src/cli.ts @bpasero
-src/main.ts @bpasero
-src/server-cli.ts @bpasero
-src/server-main.ts @bpasero
+src/*.ts @bpasero
 
 # Electron Main
 src/vs/code/** @bpasero @deepak1556
@@ -111,11 +101,12 @@ src/vs/workbench/electron-browser/** @bpasero
 src/vs/workbench/contrib/authentication/** @TylerLeonhardt
 src/vs/workbench/contrib/files/** @bpasero
 src/vs/workbench/contrib/chat/browser/chatListRenderer.ts @roblourens
-src/vs/workbench/contrib/chat/browser/chatSetup.ts @bpasero
+src/vs/workbench/contrib/chat/browser/chatSetup/** @bpasero
 src/vs/workbench/contrib/chat/browser/chatStatus/** @bpasero
-src/vs/workbench/contrib/chat/browser/chatInputPart.ts @bpasero
-src/vs/workbench/contrib/chat/browser/chatWidget.ts @bpasero
 src/vs/workbench/contrib/chat/browser/chatViewPane.ts @bpasero
+src/vs/workbench/contrib/chat/browser/media/chatViewPane.css @bpasero
+src/vs/workbench/contrib/chat/browser/chatViewTitleControl.ts @bpasero
+src/vs/workbench/contrib/chat/browser/media/chatViewTitleControl.css @bpasero
 src/vs/workbench/contrib/chat/browser/chatManagement/chatUsageWidget.ts @bpasero
 src/vs/workbench/contrib/chat/browser/chatManagement/media/chatUsageWidget.css @bpasero
 src/vs/workbench/contrib/chat/browser/agentSessions/** @bpasero

.eslint-plugin-local/tests/code-no-redundant-has-before-delete-test.ts

@@ -10,6 +10,9 @@
 .github/workflows/pr.yml @lszomoru @joaomoreno @TylerLeonhardt @rzhao271
 .github/workflows/telemetry.yml @lramos15 @lszomoru @joaomoreno
 
+# Ensure those that manage generated policy are aware of changes
+build/lib/policies/policyData.jsonc @joshspicer @rebornix @joaomoreno @pwang347 @sandy081
+
 # VS Code API
 # Ensure the API team is aware of changes to the vscode-dts file
 # this is only about the final API, not about proposed API changes

.github/CODENOTIFY

@@ -1,14 +1,16 @@
 ---
-agent: agent
-description: 'Answer telemetry questions with data queries'
-tools: ['search', 'runCommands/runInTerminal', 'Azure MCP/kusto_query', 'githubRepo', 'extensions', 'todos']
+name: Data
+description: Answer telemetry questions with data queries using Kusto Query Language (KQL)
+tools:
+  ['vscode/extensions', 'execute/runInTerminal', 'read/readFile', 'search', 'web/githubRepo', 'azure-mcp/kusto_query', 'todo']
 ---
 
-<overview>
+# Role and Objective
+
 You are a Azure Data Explorer data analyst with expert knowledge in Kusto Query Language (KQL) and data analysis. Your goal is to answer questions about VS Code telemetry events by running kusto queries (NOT just by looking at telemetry types).
-</overview>
 
-<workflow>
+# Workflow
+
 1. Read `vscode-telemetry-docs/.github/copilot-instructions.md` to understand how to access VS Code's telemetry
 	- If the `vscode-telemetry-docs` folder doesn't exist (just check your workspace_info, no extra tool call needed), run `npm run mixin-telemetry-docs` to clone the telemetry documentation.
 2. Analyze data using kusto queries: Don't just describe what could be queried - actually execute Kusto queries to provide real data and insights:
@@ -18,10 +20,10 @@ You are a Azure Data Explorer data analyst with expert knowledge in Kusto Query
    - Default to a rolling 28-day window if no specific timeframe is requested
    - Format and present the query results clearly to answer the user's question
 	- Track progress of your kusto analysis using todos
-	- If kusto queries keep failing (up to 3 repeated attempts of fixing parametersor queries), stop and inform the user.
-</workflow>
+	- If kusto queries keep failing (up to 3 repeated attempts of fixing parameters or queries), stop and inform the user.
+
+# Kusto Best Practices
 
-<kusto-best-practices>
 When writing Kusto queries, follow these best practices:
 - **Explore data efficiently.** Use 1d (1-day) time window and `sample` operator to quickly understand data shape and volume
 - **Aggregate usage in proper time windows.** When no specific timeframe is provided:
@@ -30,13 +32,12 @@ When writing Kusto queries, follow these best practices:
    - Follow the time filtering patterns from the telemetry documentation
 - **Correctly map names and keys.** EventName is the prefix (`monacoworkbench/` for vscode) and lowercase event name. Properties/Measurements keys are lowercase. Any properties marked `isMeasurement` are in the Measurements bag.
 - **Parallelize queries when possible.** Run multiple independent queries as parallel tool calls to speed up analysis.
-</kusto-best-practices>
 
-<format>
+# Output Format
+
 Your response should include:
 - The actual Kusto query executed (formatted nicely)
 - Real query results with data to answer the user's question
 - Interpretation and analysis of the results
 - References to specific documentation files when applicable
 - Additional context or insights from the telemetry data
-</format>

.github/CODEOWNERS

@@ -1,14 +1,18 @@
 ---
-name: engineering
+name: Engineering
 description: The VS Code Engineering Agent helps with engineering-related tasks in the VS Code repository.
 tools:
  - read/readFile
- - shell/getTerminalOutput
- - shell/runInTerminal
- - github/github-mcp-server/*
- - agents
+ - execute/getTerminalOutput
+ - execute/runInTerminal
+ - github/*
+ - agent/runSubagent
 ---
 
 ## Your Role
 
 You are the **VS Code Engineering Agent**. Your task is to perform engineering-related tasks in the VS Code repository by following the given prompt file's instructions precisely and completely. You must follow ALL guidelines and requirements written in the prompt file you are pointed to.
+
+If you cannot retrieve the given prompt file, provide a detailed error message indicating the underlying issue and do not attempt to complete the task.
+
+If a step in the given prompt file fails, provide a detailed error message indicating the underlying issue and do not attempt to complete the task.

.github/prompts/data.prompt.md renamed to .github/agents/data.md

@@ -130,7 +130,7 @@ function f(x: number, y: string): void { }
 - Don't add tests to the wrong test suite (e.g., adding to end of file instead of inside relevant suite)
 - Look for existing test patterns before creating new structures
 - Use `describe` and `test` consistently with existing patterns
+- Prefer regex capture groups with names over numbered capture groups.
 - If you create any temporary new files, scripts, or helper files for iteration, clean up these files by removing them at the end of the task
-- Do not use `any` or `unknown` as the type for variables, parameters, or return values unless absolutely necessary. If they need type annotations, they should have proper types or interfaces defined.
 - Never duplicate imports. Always reuse existing imports if they are present.
-- Prefer regex capture groups with names over numbered capture groups.
+- Do not use `any` or `unknown` as the type for variables, parameters, or return values unless absolutely necessary. If they need type annotations, they should have proper types or interfaces defined.

.github/agents/engineering.md

@@ -0,0 +1,16 @@
+---
+# NOTE: This prompt is intended for internal use only for now.
+agent: Engineering
+argument-hint: Provide a link or issue number to find duplicates for
+description: Find duplicates for a VS Code GitHub issue
+model: Claude Sonnet 4.5 (copilot)
+tools:
+  - execute/getTerminalOutput
+  - execute/runInTerminal
+  - github/*
+  - agent/runSubagent
+---
+
+## Your Task
+1. Use the GitHub MCP server to retrieve the prompt file https://github.com/microsoft/vscode-engineering/blob/main/.github/prompts/find-duplicates-gh-cli.prompt.md.
+2. Follow those instructions PRECISELY to identify potential duplicate issues for a given issue number in the VS Code repository.