Fix duplicated file changes part for background sessions #281635
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Fix duplicated file changes for background session
Fix duplicated file changes part for background sessions
Dec 5, 2025
When chat.checkpoints.showFileChanges is enabled, only show file changes summary for local sessions since background sessions already have their own file changes part registered. Co-authored-by: osortega <[email protected]>
osortega
force-pushed
the
copilot/fix-duplicated-file-changes
branch
from
d3216dd to
c28da72
Compare
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @roblourensMatched files:
|
osortega
approved these changes
Dec 6, 2025
rebornix
approved these changes
Dec 9, 2025
roblourens
reviewed
Dec 9, 2025
|
|
||
| private shouldShowFileChangesSummary(element: IChatResponseViewModel): boolean { | ||
| return element.isComplete && this.configService.getValue<boolean>('chat.checkpoints.showFileChanges'); | ||
| // Only show file changes summary for local sessions - background sessions already have their own file changes part |
Member
There was a problem hiding this comment.
background sessions already have their own file changes part
How does that work? How can we get rid of these special cases?
bpasero
pushed a commit
that referenced
this pull request
Dec 9, 2025
* Initial plan * Fix duplicated file changes for background sessions When chat.checkpoints.showFileChanges is enabled, only show file changes summary for local sessions since background sessions already have their own file changes part registered. Co-authored-by: osortega <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: osortega <[email protected]> Co-authored-by: Peng Lyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
chat.checkpoints.showFileChangesis enabled, the checkpoint file changes summary was displayed for background (non-local) sessions. Background sessions already register their own file changes part, causing duplicate UI elements.Changes
shouldShowFileChangesSummaryinchatListRenderer.tsto check session type before renderinglocalChatSessionType) now show the checkpoint file changes partOriginal prompt
chat.checkpoints.showFileChangesis turned on #281630💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.