Skip to content

fix: memory leak in debug session #281767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimonSiefke wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: memory leak in debug session #281767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/vs/workbench/contrib/debug/browser/debugSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ import { RawDebugSession } from './rawDebugSession.js';

const TRIGGERED_BREAKPOINT_MAX_DELAY = 1500;

export class DebugSession implements IDebugSession {
export class DebugSession extends Disposable implements IDebugSession {
parentSession: IDebugSession | undefined;
rememberedCapabilities?: DebugProtocol.Capabilities;

Expand Down Expand Up @@ -122,6 +122,7 @@ export class DebugSession implements IDebugSession {
@ITestResultService testResultService: ITestResultService,
@IAccessibilityService private readonly accessibilityService: IAccessibilityService,
) {
super();
this._options = options || {};
this.parentSession = this._options.parentSession;
if (this.hasSeparateRepl()) {
Expand Down Expand Up @@ -1494,13 +1495,19 @@ export class DebugSession implements IDebugSession {
this.passFocusScheduler.cancel();
this.passFocusScheduler.dispose();
this.model.clearThreads(this.getId(), true);
this.sources.clear();
this.threads.clear();
this.threadIds = [];
this.stoppedDetails = [];
this._onDidChangeState.fire();
}

public dispose() {
override dispose() {
this.cancelAllRequests();
this.rawListeners.dispose();
this.globalDisposables.dispose();
this._waitToResume = undefined;
super.dispose();
}

//---- sources
Expand Down