Add a log for the url #282098
Merged
Add a log for the url #282098
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it's clear what fails. We saw rate limiting from GH EDU.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds logging to help diagnose rate limiting issues from GitHub EDU endpoints. The changes add debug logging for fetch attempts in the node fetch implementation and info-level error logging when EDU details resolution fails.
Key changes:
- Added debug log to track which fetcher is being tried for which URL
- Added info logs for both HTTP status failures and exceptions when resolving EDU details
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| extensions/github-authentication/src/node/fetch.ts | Adds debug logging at the start of each fetch attempt to log the fetcher name and target URL |
| extensions/github-authentication/src/githubServer.ts | Adds info-level logging for both HTTP status failures and caught exceptions when resolving optional EDU details |
rzhao271
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it's clear what fails. We saw rate limiting from GH EDU.